helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [helix] branch master updated: Remove unnecessary touch logics that trigge pipeline
Date Fri, 02 Aug 2019 16:02:46 GMT
This is an automated email from the ASF dual-hosted git repository.

jxue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new dbbc36d  Remove unnecessary touch logics that trigge pipeline
dbbc36d is described below

commit dbbc36d412875c6b556e94d2d007461f7e5f1dda
Author: Ali Reza Zamani Zadeh Najari <anajari@linkedin.com>
AuthorDate: Thu Aug 1 10:54:28 2019 -0700

    Remove unnecessary touch logics that trigge pipeline
    
    In the places that ZooKeeper Resourceconfig is updated,
    it is not necessary to do touch logic anymore to run the pipeline again.
    Resourcesconfig update automatically runs triggers pipeline.
    
    This commit fixes issue #370.
---
 helix-core/src/main/java/org/apache/helix/task/TaskDriver.java | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java b/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
index bf4fdf6..6ec8260 100644
--- a/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
+++ b/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
@@ -215,8 +215,6 @@ public class TaskDriver {
     if (!TaskUtil.setWorkflowConfig(_accessor, workflow, newWorkflowConfig)) {
       LOG.error("Failed to update workflow configuration for workflow " + workflow);
     }
-
-    RebalanceScheduler.invokeRebalance(_accessor, workflow);
   }
 
   /**
@@ -496,8 +494,6 @@ public class TaskDriver {
     // This is to make it back-compatible with old Helix task driver.
     addWorkflowResourceIfNecessary(queue);
 
-    // Schedule the job
-    RebalanceScheduler.invokeRebalance(_accessor, queue);
   }
 
   /**
@@ -794,7 +790,6 @@ public class TaskDriver {
     PropertyKey workflowConfigKey = TaskUtil.getWorkflowConfigKey(_accessor, workflow);
     _accessor.getBaseDataAccessor().update(workflowConfigKey.getPath(), updater,
         AccessOption.PERSISTENT);
-    RebalanceScheduler.invokeRebalance(_accessor, workflow);
   }
 
   public WorkflowConfig getWorkflowConfig(String workflow) {


Mime
View raw message