hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas M Nair (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-10122) Hive metastore filter-by-expression is broken for non-partition expressions
Date Tue, 07 Apr 2015 22:58:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484280#comment-14484280
] 

Thejas M Nair commented on HIVE-10122:
--------------------------------------

yeah, it would be really good to have unit tests for these. That would have detected this
regression in the first place.
If logs need to be looked at, that is also possible. See my changes to TestHive in HIVE-10214,
its easy to capture log output from specific classes.


> Hive metastore filter-by-expression is broken for non-partition expressions
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-10122
>                 URL: https://issues.apache.org/jira/browse/HIVE-10122
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.14.0, 1.0.0, 1.1.0
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-10122.patch
>
>
> See https://issues.apache.org/jira/browse/HIVE-10091?focusedCommentId=14382413&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14382413
> These two lines of code
> {noformat}
>     // Replace virtual columns with nulls. See javadoc for details.
>     prunerExpr = removeNonPartCols(prunerExpr, extractPartColNames(tab), partColsUsedInFilter);
>     // Remove all parts that are not partition columns. See javadoc for details.
>     ExprNodeDesc compactExpr = compactExpr(prunerExpr.clone());
> {noformat}
> are supposed to take care of this; I see there were bunch of changes to this code over
some time, and now it appears to be broken.
> Thanks to [~thejas] for info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message