hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Sankar Sivarama Subramaniyan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-10477) Provide option to disable Spark tests
Date Sat, 25 Apr 2015 10:42:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512384#comment-14512384
] 

Hari Sankar Sivarama Subramaniyan commented on HIVE-10477:
----------------------------------------------------------

1. The test failures are unrelated to the change.
2. http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3583/testReport/org.apache.hadoop.hive.cli/TestSparkCliDriver/
shows that we run spark tests by default
3. # tests executed between this build and previous build is the same, => we have not skipped
any tests proving the correctness of the default behavior.
4. Tested locally to see that if I run " mvn clean install -DskipSparkTests -DskipTests -Phadoop-2"
inside itests directory, we skip spark module.

Thanks
Hari

> Provide option to disable Spark tests 
> --------------------------------------
>
>                 Key: HIVE-10477
>                 URL: https://issues.apache.org/jira/browse/HIVE-10477
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-10477.01.patch
>
>
> The following is one of the reasons why we might want to provide an option to disable
spark tests :
> In the current master branch, unit tests fail with windows OS because of the dependency
on "bash" executable in itests/hive-unit/pom.xml around these lines :
> {code}
>                  <target>
>                     <exec executable="bash" dir="${basedir}" failonerror="true">
>                       <arg line="../target/download.sh"/>
>                     </exec>
>                   </target>
> {code}
> We should provide an option to disable spark tests in OSes  like Windows where bash might
be absent. That being mentioned, spark tests will be enabled by default in pre-commit test
runs and should still continue to work as it is in the master branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message