hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Sankar Sivarama Subramaniyan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-10514) Fix MiniCliDriver tests failure
Date Tue, 28 Apr 2015 22:08:06 GMT

    [ https://issues.apache.org/jira/browse/HIVE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518192#comment-14518192
] 

Hari Sankar Sivarama Subramaniyan commented on HIVE-10514:
----------------------------------------------------------

[~szehon] The difference is that without the patch, the suite() in TestCliDriver.java would
be huge enough to cause code size limit issues. i.e, the following line would be present in
suite for each and every qfile executed under the test suite.
  {source}
    if(qFilesToExecute.isEmpty() || qFilesToExecute.contains("$fname")) {
      suite.addTest(new $className("testCliDriver_$tname", setup));
  {source}

i.e, close to 5000+ LOC inside suite() as of today.

I didnt see a direct way of avoid writing the qfile names to a temporary file or storing it
somewhere so that they can be iterated at test suite runtime. Please let me know if there
is an easier approach I missed.

Thanks
Hari

> Fix MiniCliDriver tests failure
> -------------------------------
>
>                 Key: HIVE-10514
>                 URL: https://issues.apache.org/jira/browse/HIVE-10514
>             Project: Hive
>          Issue Type: Bug
>          Components: Testing Infrastructure
>            Reporter: Szehon Ho
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-10514.1.patch, HIVE-10514.2.patch
>
>
> The MinimrCliDriver tests always fail to run.
> This can be reproduced by the following, run the command:
> {noformat}
> mvn -B test -Phadoop-2 -Dtest=TestMinimrCliDriver -Dminimr.query.files=infer_bucket_sort_map_operators.q,join1.q,bucketmapjoin7.q,udf_using.q
> {noformat}
> And the following exception comes:
> {noformat}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
(default-testCompile) on project hive-it-qfile: Compilation failure
> [ERROR] /Users/szehon/repos/apache-hive-git/hive/itests/qtest/target/generated-test-sources/java/org/apache/hadoop/hive/cli/TestCliDriver.java:[100,22]
code too large
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message