hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanth Jayachandran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11259) LLAP: clean up ORC dependencies part 1
Date Tue, 21 Jul 2015 22:28:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635943#comment-14635943
] 

Prasanth Jayachandran commented on HIVE-11259:
----------------------------------------------

Moving interfaces to common looks good to me.
Some comments related to simplifying the code
1) There are many Chunk classes that inherit from DiskRange. BufferChunk, CacheChunk, ProcCacheChunk,
TrackedCacheChunk, UncompressedCacheChunk, DiskRange, DiskRangeList. I am not sure if we need
all of them. I see the purpose of BufferChunk, CacheChunk and DiskRange. But others seems
to be an overkill. Can you move the flags/variables (isCompressed, isReleased etc.) to CacheChunk?
2) Can the DiskRangeList purpose can be replaced by TreeMap? Using offset as the key comparator,
lowerKey(), higherKey() methods for merging in case of any overlap.
3) Replace BooleanRef with Boolean?

> LLAP: clean up ORC dependencies part 1
> --------------------------------------
>
>                 Key: HIVE-11259
>                 URL: https://issues.apache.org/jira/browse/HIVE-11259
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-11259.patch
>
>
> Before there's storage handler module, we can clean some things up



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message