hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raajay Viswanathan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11413) Error in detecting availability of HiveSemanticAnalyzerHooks
Date Mon, 03 Aug 2015 05:12:05 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651443#comment-14651443
] 

Raajay Viswanathan commented on HIVE-11413:
-------------------------------------------

Hi Sergio - 
>From looking at the current code,  {{saHooks}} cannot be NULL. However, I agree that is
better to add the NULL check to errorproof against future changes.

> Error in detecting availability of HiveSemanticAnalyzerHooks
> ------------------------------------------------------------
>
>                 Key: HIVE-11413
>                 URL: https://issues.apache.org/jira/browse/HIVE-11413
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 2.0.0
>            Reporter: Raajay Viswanathan
>            Assignee: Raajay Viswanathan
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 2.0.0
>
>         Attachments: HIVE-11413.patch
>
>
> In {{compile(String, Boolean)}} function in {{Driver.java}}, the list of available {{HiveSemanticAnalyzerHook}}
(_saHooks_) are obtained using the {{getHooks}} method. This method always  returns a {{List}}
of hooks. 
> However, while checking for availability of hooks, the current version of the code uses
a comparison of _saHooks_ with NULL. This is incorrect, as the segment of code designed to
call pre and post Analyze functions gets executed even when the list is empty. The comparison
should be changed to {{saHooks.size() > 0}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message