hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11477) CBO inserts a UDF cast for integer type promotion (only for negative numbers)
Date Sun, 09 Aug 2015 22:31:45 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679386#comment-14679386
] 

Hive QA commented on HIVE-11477:
--------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12749400/HIVE-11477.02.patch

{color:red}ERROR:{color} -1 due to 21 failed/errored test(s), 9345 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input_part6
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_lineage3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_orc_predicate_pushdown
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_select_unquote_and
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_select_unquote_not
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_select_unquote_or
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_temp_table_windowing_expressions
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_6_subq
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_uniquejoin
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vector_decimal_round
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vectorization_short_regress
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_windowing_expressions
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_vector_decimal_round
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_vectorization_short_regress
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_udf_format_number_wrong3
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_union_remove_6_subq
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_uniquejoin
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_vectorization_short_regress
org.apache.hadoop.hive.ql.parse.TestHiveDecimalParse.testDecimalType6
org.apache.hadoop.hive.ql.parse.TestIUD.testInsertIntoTableFromAnonymousTable
org.apache.hadoop.hive.ql.parse.TestIUD.testUpdateWithWhereSingleSetExpr
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4893/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4893/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4893/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 21 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12749400 - PreCommit-HIVE-TRUNK-Build

> CBO inserts a UDF cast for integer type promotion (only for negative numbers)
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-11477
>                 URL: https://issues.apache.org/jira/browse/HIVE-11477
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Pengcheng Xiong
>            Priority: Critical
>         Attachments: HIVE-11477.01.patch, HIVE-11477.02.patch
>
>
> When CBO is enabled, filters which compares tinyint, smallint columns with constant integer
types will insert a UDFToInteger cast for the columns. When CBO is disabled, there is no such
UDF. This behaviour breaks ORC predicate pushdown feature as ORC ignores UDFs in the filters.
> In the following examples column t is tinyint
> {code:title=Explain for select count(*) from orc_ppd where t < -127; (CBO OFF)}
> Filter Operator [FIL_9]
>                            predicate:(t = 125) (type: boolean)
>                            Statistics:Num rows: 1050 Data size: 611757 Basic stats: COMPLETE
Column stats: NONE
>                            TableScan [TS_0]
>                               alias:orc_ppd
>                               Statistics:Num rows: 2100 Data size: 1223514 Basic stats:
COMPLETE Column stats: NONE
> {code}
> {code:title=Explain for select count(*) from orc_ppd where t < -127; (CBO ON)}
> Filter Operator [FIL_10]
>                            predicate:(UDFToInteger(t) < -127) (type: boolean)
>                            Statistics:Num rows: 700 Data size: 407838 Basic stats: COMPLETE
Column stats: NONE
>                            TableScan [TS_0]
>                               alias:orc_ppd
>                               Statistics:Num rows: 2100 Data size: 1223514 Basic stats:
COMPLETE Column stats: NONE
> {code}
> CBO does not insert such cast for non-negative numbers
> {code:title=Explain for select count(*) from orc_ppd where t < 127; (CBO ON)}
> Filter Operator [FIL_10]
>                            predicate:(t < 127) (type: boolean)
>                            Statistics:Num rows: 700 Data size: 407838 Basic stats: COMPLETE
Column stats: NONE
>                            TableScan [TS_0]
>                               alias:orc_ppd
>                               Statistics:Num rows: 2100 Data size: 1223514 Basic stats:
COMPLETE Column stats: NONE
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message