hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11552) implement basic methods for getting/putting file metadata
Date Mon, 24 Aug 2015 18:28:45 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709803#comment-14709803
] 

Sergey Shelukhin commented on HIVE-11552:
-----------------------------------------

The way code is currently implemented, the method already bails fast
{noformat}
      List<Long> fileIds = req.getFileIds();
      ByteBuffer[] metadatas = getMS().getFileMetadata(fileIds);
      GetFileMetadataResult result = new GetFileMetadataResult();
      result.setIsSupported(metadatas != null);
      if (metadatas != null) {
[snip]
      }
      return result;
{noformat}

It will be the same path with extra call otherwise.
For put and clear, the methods in ObjectStore are just a no-op.

> implement basic methods for getting/putting file metadata
> ---------------------------------------------------------
>
>                 Key: HIVE-11552
>                 URL: https://issues.apache.org/jira/browse/HIVE-11552
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: hbase-metastore-branch
>
>         Attachments: HIVE-11552.01.patch, HIVE-11552.nogen.patch, HIVE-11552.nogen.patch,
HIVE-11552.patch
>
>
> NO PRECOMMIT TESTS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message