hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olaf Flebbe (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-12417) Support for exclamation mark missing in regexp
Date Mon, 16 Nov 2015 14:58:10 GMT

     [ https://issues.apache.org/jira/browse/HIVE-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Olaf Flebbe updated HIVE-12417:
-------------------------------
    Description: 
with HIVE-6013 gets support for regular expressions. However, die ! character is valid, too.
It is needed for expressions like 

{code}
set hive.support.quoted.identifiers = none;
select `^(?!donotuseme).*$` from table;
{code}

which is the idiom to select all but column {{donotuseme}} .

See http://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html for a reference
of supported chars in Java regexp.

The patch simply fixes the lexer to support '!' as REGEX char. And does simply work.

Please review. 

If you like to have an iTest for it, I beg you to help me. I tried several days on a different
issue to figure out how it is supposed to work and failed miserably.

  was:
with HIVE-6013 gets support for regular expressions. However, die ! character is valid, too.
It is needed for expressions like 

{code}
set hive.support.quoted.identifiers = none;
select '^(?!donotuseme).*$ from table;
{code}

which is the idiom to select all but column {{donotuseme}} .

See http://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html for a reference
of supported chars in Java regexp.

The patch simply fixes the lexer to support '!' as REGEX char. And does simply work.

Please review. 

If you like to have an iTest for it, I beg you to help me. I tried several days on a different
issue to figure out how it is supposed to work and failed miserably.


> Support for exclamation mark missing in regexp
> ----------------------------------------------
>
>                 Key: HIVE-12417
>                 URL: https://issues.apache.org/jira/browse/HIVE-12417
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 1.2.1
>            Reporter: Olaf Flebbe
>            Assignee: Olaf Flebbe
>         Attachments: HIVE-12417.1.patch
>
>
> with HIVE-6013 gets support for regular expressions. However, die ! character is valid,
too. It is needed for expressions like 
> {code}
> set hive.support.quoted.identifiers = none;
> select `^(?!donotuseme).*$` from table;
> {code}
> which is the idiom to select all but column {{donotuseme}} .
> See http://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html for a reference
of supported chars in Java regexp.
> The patch simply fixes the lexer to support '!' as REGEX char. And does simply work.
> Please review. 
> If you like to have an iTest for it, I beg you to help me. I tried several days on a
different issue to figure out how it is supposed to work and failed miserably.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message