hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12753) Improve performance of LazyBinaryColumnarSerDe for Text strings
Date Tue, 05 Jan 2016 07:04:39 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082545#comment-15082545
] 

Heng Chen commented on HIVE-12753:
----------------------------------

What's the meaning of the failed testcase? relates with this patch?

> Improve performance of LazyBinaryColumnarSerDe for Text strings
> ---------------------------------------------------------------
>
>                 Key: HIVE-12753
>                 URL: https://issues.apache.org/jira/browse/HIVE-12753
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 1.2.1
>            Reporter: David Phillips
>         Attachments: HIVE-12753.patch
>
>
> {{LazyBinaryColumnarSerDe}} needs to special case writing empty strings, but it does
so by calling {{getPrimitiveJavaObject()}} rather than {{getPrimitiveWritableObject()}} on
{{StringObjectInspector}}. If the object is {{Text}}, then this requires a conversion to a
Java {{String}} just to get the length.
> Unfortunately, the best method to call depends on the object type (or the object inspector
type). One solution is to call {{getPrimitiveWritableObject()}} if the object is an instance
of {{Text}} or {{BytesWritable}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message