hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesus Camacho Rodriguez (JIRA)" <>
Subject [jira] [Commented] (HIVE-12686) TxnHandler.checkLock(CheckLockRequest) perf improvements
Date Wed, 25 May 2016 16:26:13 GMT


Jesus Camacho Rodriguez commented on HIVE-12686:

Removing 2.1.0 target. Please feel free to commit to branch-2.1 anyway and fix for 2.1.0 if
this happens before the release.

> TxnHandler.checkLock(CheckLockRequest) perf improvements
> --------------------------------------------------------
>                 Key: HIVE-12686
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 1.3.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
> CheckLockRequest should include txnid since the caller should always know this (if there
is a txn).
> This would make getTxnIdFromLockId() call unnecessary.
> checkLock() is usually called much more often (especially at the beginning of exponential
back off sequence), thus a lot of these heartbeats are overkill.  Could also include a time
(in ms) since last checkLock() was called and use that to decide to heartbeat or not.
> In fact, if we made heartbeat in DbTxnManager start right after locks in "W" state are
inserted, heartbeat in checkLock() would not be needed at all.
> This would be the best solution but need to make sure that heartbeating is started appropriately
in Streaming API - currently it does not.  It requires the client to start heartbeating.

This message was sent by Atlassian JIRA

View raw message