hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-13458) Heartbeater doesn't fail query when heartbeat fails
Date Tue, 10 May 2016 21:26:12 GMT

     [ https://issues.apache.org/jira/browse/HIVE-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Wei Zheng updated HIVE-13458:
-----------------------------
    Attachment: HIVE-13458.9.patch

Upload patch 9.

Set queryId to null at the end of stopHeartbeat.
Call acquireLocksWithHeartbeatDelay from acquireLocks(QueryPlan, Context, String).
The reason for qfile changes is that, there's a bug in ExecDriver, which didn't record the
exception properly, so in my unit test I found this bug (I was not able to assert the exception
message). After the fix, 2 negative qfile outputs changed slightly, which should be fine.

> Heartbeater doesn't fail query when heartbeat fails
> ---------------------------------------------------
>
>                 Key: HIVE-13458
>                 URL: https://issues.apache.org/jira/browse/HIVE-13458
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 2.1.0
>            Reporter: Wei Zheng
>            Assignee: Wei Zheng
>         Attachments: HIVE-13458.1.patch, HIVE-13458.2.patch, HIVE-13458.3.patch, HIVE-13458.4.patch,
HIVE-13458.5.patch, HIVE-13458.6.patch, HIVE-13458.7.patch, HIVE-13458.8.patch, HIVE-13458.9.patch
>
>
> When a heartbeat fails to locate a lock, it should fail the current query. That doesn't
happen, which is a bug.
> Another thing is, we need to make sure stopHeartbeat really stops the heartbeat, i.e.
no additional heartbeat will be sent, since that will break the assumption and cause the query
to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message