hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13380) Decimal should have lower precedence than double in type hierachy
Date Thu, 09 Jun 2016 20:34:21 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323288#comment-15323288
] 

Ashutosh Chauhan commented on HIVE-13380:
-----------------------------------------

hmm.. its arguable. As I noted in my previous comment if one of the sides in comparison is
inexact there is no way to perform exact arithmetic operation. From their documentation both
SQL Server & Oracle seems to treat decimal lower in hierarchy which motivated this change.
Plus, since HiveDecimal is based on BigDecimal it is dog slow, so doing operation in Double
would also be more performant. 

We can revert the patch but then we won't follow SQL Server & Oracle type's hierarchy
which likely means we won't follow ansi standards.

> Decimal should have lower precedence than double in type hierachy
> -----------------------------------------------------------------
>
>                 Key: HIVE-13380
>                 URL: https://issues.apache.org/jira/browse/HIVE-13380
>             Project: Hive
>          Issue Type: Bug
>          Components: Types
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>              Labels: TODOC2.1
>             Fix For: 2.1.0
>
>         Attachments: HIVE-13380.2.patch, HIVE-13380.4.patch, HIVE-13380.5.patch, HIVE-13380.patch,
decimal_filter.q
>
>
> Currently its other way round. Also, decimal should be lower than float.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message