hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergio Peña (JIRA) <j...@apache.org>
Subject [jira] [Commented] (HIVE-13617) LLAP: support non-vectorized execution in IO
Date Mon, 13 Jun 2016 16:04:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327652#comment-15327652
] 

Sergio Peña commented on HIVE-13617:
------------------------------------

[~sershe] Your change should have worked fine. I see that minillap.query.files is excluded
from TestCliDriver. 
This is part of {{itests/qtest/pom.xml}}
{noformat}
<qtestgen hiveRootDirectory="${basedir}/${hive.path.to.root}/"
   ...
   queryDirectory="${basedir}/${hive.path.to.root}/ql/src/test/queries/clientpositive/"
   ...
   excludeQueryFile=${minillap.query.files},${minimr.query.files},${minitez.query.files},${encrypted.query.files},${spark.only.query.files},${disabled.query.files}"
   ...
   resultsDirectory="${basedir}/${hive.path.to.root}/ql/src/test/results/clientpositive/"
className="TestCliDriver"
   ...
  cleanupScript="q_test_cleanup.sql"/>
{noformat}

Have you tried to run the same .q file from TestCliDriver to see if it is executed in your
environment?

> LLAP: support non-vectorized execution in IO
> --------------------------------------------
>
>                 Key: HIVE-13617
>                 URL: https://issues.apache.org/jira/browse/HIVE-13617
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-13617-wo-11417.patch, HIVE-13617-wo-11417.patch, HIVE-13617.01.patch,
HIVE-13617.03.patch, HIVE-13617.04.patch, HIVE-13617.05.patch, HIVE-13617.06.patch, HIVE-13617.patch,
HIVE-13617.patch, HIVE-15396-with-oi.patch
>
>
> Two approaches - a separate decoding path, into rows instead of VRBs; or decoding VRBs
into rows on a higher level (the original LlapInputFormat). I think the latter might be better
- it's not a hugely important path, and perf in non-vectorized case is not the best anyway,
so it's better to make do with much less new code and architectural disruption. 
> Some ORC patches in progress introduce an easy to reuse (or so I hope, anyway) VRB-to-row
conversion, so we should just use that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message