hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14048) patch for HIVE-4570 removes protected fields which can break dependencies
Date Fri, 17 Jun 2016 18:46:05 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336677#comment-15336677
] 

Ashutosh Chauhan commented on HIVE-14048:
-----------------------------------------

Those fields are not of public api, there is no contract that we need to deprecate them before
removing them.  Dependencies which are using non-public apis need to update their source if
they rely on non-public apis.

> patch for HIVE-4570 removes protected fields which can break dependencies
> -------------------------------------------------------------------------
>
>                 Key: HIVE-14048
>                 URL: https://issues.apache.org/jira/browse/HIVE-14048
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Critical
>
> The patch for HIVE-4570 removes protected fields like initialized, isDone, started etc
and created a TaskState enum to represent these variables. Since these fields which were removed
were marked protected, class which can extend Task.java (or DDLTask.java) will fail to compile
once they get this patch.
> The protected fields should probably be marked deprecated instead of removing them directly
since it could break outside dependencies.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message