hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <>
Subject [jira] [Updated] (HIVE-10022) Authorization checks for non existent file/directory should not be recursive
Date Tue, 26 Jul 2016 01:06:20 GMT


Sushanth Sowmyan updated HIVE-10022:
    Attachment: HIVE-10022.9.patch

Updated .9.patch, Difference between .8.patch and .9.patch is over at :

> Authorization checks for non existent file/directory should not be recursive
> ----------------------------------------------------------------------------
>                 Key: HIVE-10022
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Authorization
>    Affects Versions: 0.14.0
>            Reporter: Pankit Thapar
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-10022.2.patch, HIVE-10022.3.patch, HIVE-10022.4.patch, HIVE-10022.5.patch,
HIVE-10022.6.patch, HIVE-10022.7.patch, HIVE-10022.8.patch, HIVE-10022.9.patch, HIVE-10022.patch
> I am testing a query like : 
> set hive.test.authz.sstd.hs2.mode=true;
> set;
> set;
> set;
> set;
> create table auth_noupd(i int) clustered by (i) into 2 buckets stored as orc location
'${OUTPUT}' TBLPROPERTIES ('transactional'='true');
> Now, in the above query,  since authorization is true, 
> we would end up calling doAuthorizationV2() which ultimately ends up calling SQLAuthorizationUtils.getPrivilegesFromFS()
which calls a recursive method : FileUtils.isActionPermittedForFileHierarchy() with the object
or the ancestor of the object we are trying to authorize if the object does not exist. 
> The logic in FileUtils.isActionPermittedForFileHierarchy() is DFS.
> Now assume, we have a path as a/b/c/d that we are trying to authorize.
> In case, a/b/c/d does not exist, we would call FileUtils.isActionPermittedForFileHierarchy()
with say a/b/ assuming a/b/c also does not exist.
> If under the subtree at a/b, we have millions of files, then FileUtils.isActionPermittedForFileHierarchy()
 is going to check file permission on each of those objects. 
> I do not completely understand why do we have to check for file permissions in all the
objects in  branch of the tree that we are not  trying to read from /write to.  
> We could have checked file permission on the ancestor that exists and if it matches what
we expect, the return true.
> Please confirm if this is a bug so that I can submit a patch else let me know what I
am missing ?

This message was sent by Atlassian JIRA

View raw message