hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-15511) Provide an option in months_between UDF to disable rounding-off
Date Mon, 26 Dec 2016 07:23:58 GMT

    [ https://issues.apache.org/jira/browse/HIVE-15511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15777768#comment-15777768
] 

Hive QA commented on HIVE-15511:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12844657/HIVE-15511.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10896 tests executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=234)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_months_between] (batchId=48)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a] (batchId=135)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[escape1] (batchId=138)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_notin] (batchId=150)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=93)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3] (batchId=92)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_5] (batchId=92)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2725/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2725/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2725/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12844657 - PreCommit-HIVE-Build

> Provide an option in months_between UDF to disable rounding-off
> ---------------------------------------------------------------
>
>                 Key: HIVE-15511
>                 URL: https://issues.apache.org/jira/browse/HIVE-15511
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>            Priority: Minor
>         Attachments: HIVE-15511.1.patch, HIVE-15511.2.patch
>
>
> Rounding off was added in {{GenericUDFMonthsBetween}} so that it can be compatible with
systems like oracle. However, there are places where rounding off is not needed. 
> E.g "CAST(MONTHS_BETWEEN(l_shipdate, l_commitdate) / 12 AS INT)" may not need rounding
off via BigDecimal which is compute intensive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message