hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17425) Change MetastoreConf.ConfVars internal members to be private
Date Fri, 01 Sep 2017 19:17:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151040#comment-16151040
] 

Alan Gates commented on HIVE-17425:
-----------------------------------

[~sershe], MetastoreConf does support legacy names, meaning that if it's handed a config file
with the names from Hive, or even a HiveConf object, it will work as expected.  This patch
is about changing the internals of it so it makes it harder for developers to accidentally
break that.  By using the getVar and related methods, developers can guarantee both new and
old values are checked.  If they call conf.get(key) directly, MetastoreConf can't make sure
it checks both old and new values.  So I'm changing the key names to be private (with a getter
that has comments on why it shouldn't be used) to developers don't mess up and make the wrong
call.

> Change MetastoreConf.ConfVars internal members to be private
> ------------------------------------------------------------
>
>                 Key: HIVE-17425
>                 URL: https://issues.apache.org/jira/browse/HIVE-17425
>             Project: Hive
>          Issue Type: Task
>          Components: Metastore
>    Affects Versions: 3.0.0
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: HIVE-17425.patch
>
>
> MetastoreConf's dual use of metastore keys and Hive keys is causing confusion for developers.
 We should make the relevant members private and provide getter methods with comments on when
it is appropriate to use them.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message