hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <>
Subject [jira] [Commented] (HIVE-17482) External LLAP client: acquire locks for tables queried directly by LLAP
Date Mon, 11 Sep 2017 18:44:00 GMT


Sergey Shelukhin commented on HIVE-17482:

HiveTxnManager txnManager = TxnManagerFactory.getTxnManagerFactory().getTxnManager(conf);
I'm not familiar with txn manager usage patterns, is this going to be the same one used by
normal HS2 compile? cc [~ekoifman] 
+        cpr = driver.lockAndRespond(txnManager);
+        if (cpr.getResponseCode() != 0) {
+          throw new HiveException("Failed to acquire locks: " + cpr.getException());
If lock... throws or fails, the handling block will still call cleanup on the cleanup object...
is releasing locks needed, or even valid, when taking them failed?

> External LLAP client: acquire locks for tables queried directly by LLAP
> -----------------------------------------------------------------------
>                 Key: HIVE-17482
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: HIVE-17482.1.patch
> When using the LLAP external client with simple queries (filter/project of single table),
the appropriate locks should be taken on the table being read like they are for normal Hive
queries. This is important in the case of transactional tables being queried, since the compactor
relies on the presence of table locks to determine whether it can safely delete old versions
of compacted files without affecting currently running queries.
> This does not have to happen in the complex query case, since a query is used (with the
appropriate locking mechanisms) to create/populate the temp table holding the results to the
complex query.

This message was sent by Atlassian JIRA

View raw message