hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17568) HiveJoinPushTransitivePredicatesRule may exchange predicates which are not valid on the other branch
Date Mon, 25 Sep 2017 12:56:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178990#comment-16178990
] 

Hive QA commented on HIVE-17568:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12888807/HIVE-17568.03.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 11062 tests executed
*Failed tests:*
{noformat}
TestAccumuloCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=231)
TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=231)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=156)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1]
(batchId=170)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=235)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=235)
org.apache.hive.jdbc.TestJdbcDriver2.testSelectExecAsync2 (batchId=226)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6974/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6974/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6974/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12888807 - PreCommit-HIVE-Build

> HiveJoinPushTransitivePredicatesRule may exchange predicates which are not valid on the
other branch
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-17568
>                 URL: https://issues.apache.org/jira/browse/HIVE-17568
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-17568.01.patch, HIVE-17568.02.patch, HIVE-17568.03.patch
>
>
> Joining 2 tables on at least 1 column which is not the same type ; (integer/double for
example).
> The calcite expressions require double/integer inputs which will became invalid if {{HiveJoinPushTransitivePredicatesRule}}
pushes them to the other branch.
> query:
> {code}
> create table t1 (v string, k int);
> insert into t1 values ('people', 10), ('strangers', 20), ('parents', 30);
> create table t2 (v string, k double);
> insert into t2 values ('people', 10), ('strangers', 20), ('parents', 30);
> select * from t1 where t1.k in (select t2.k from t2 where t2.v='people') and t1.k<15;
> {code}
> results in:
> {code}
> java.lang.AssertionError: type mismatch:
> type1:
> DOUBLE
> type2:
> INTEGER
> 	at org.apache.calcite.util.Litmus$1.fail(Litmus.java:31)
> 	at org.apache.calcite.plan.RelOptUtil.eq(RelOptUtil.java:1841)
> 	at org.apache.calcite.rex.RexProgramBuilder$RegisterInputShuttle.visitInputRef(RexProgramBuilder.java:941)
> 	at org.apache.calcite.rex.RexProgramBuilder$RegisterInputShuttle.visitInputRef(RexProgramBuilder.java:919)
> 	at org.apache.calcite.rex.RexInputRef.accept(RexInputRef.java:112)
> 	at org.apache.calcite.rex.RexShuttle.visitList(RexShuttle.java:153)
> 	at org.apache.calcite.rex.RexShuttle.visitCall(RexShuttle.java:102)
> 	at org.apache.calcite.rex.RexProgramBuilder$RegisterShuttle.visitCall(RexProgramBuilder.java:884)
> 	at org.apache.calcite.rex.RexProgramBuilder$RegisterShuttle.visitCall(RexProgramBuilder.java:882)
> 	at org.apache.calcite.rex.RexCall.accept(RexCall.java:104)
> 	at org.apache.calcite.rex.RexProgramBuilder.registerInput(RexProgramBuilder.java:296)
> 	at org.apache.calcite.rex.RexProgramBuilder.addCondition(RexProgramBuilder.java:271)
> 	at org.apache.calcite.rel.rules.FilterMergeRule.createProgram(FilterMergeRule.java:98)
> 	at org.apache.calcite.rel.rules.FilterMergeRule.onMatch(FilterMergeRule.java:67)
> [...]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message