hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <>
Subject [jira] [Commented] (HIVE-12195) Unknown zones should cause an error instead of silently failing
Date Fri, 27 Oct 2017 16:09:00 GMT


Hive QA commented on HIVE-12195:

Here are the results of testing the latest attachment:

{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 11312 tests executed
*Failed tests:*
TestMetaStoreLimitPartitionRequest - did not produce a TEST-*.xml file (likely timed out)
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries] (batchId=234)
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc] (batchId=93)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=205)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=222)
org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerHighShuffleBytes (batchId=229)

Test results:
Console output:
Test logs:

Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed

This message is automatically generated.

ATTACHMENT ID: 12784921 - PreCommit-HIVE-Build

> Unknown zones should cause an error instead of silently failing
> ---------------------------------------------------------------
>                 Key: HIVE-12195
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Ryan Blue
>            Assignee: Shinichi Yamashita
>              Labels: timestamp
>         Attachments: HIVE-12195.1.patch, HIVE-12195.2.patch, HIVE-12195.3.patch, HIVE-12195.4.patch
> Using an unknown time zone with the {{from_utc_timestamp}} or {{to_utc_timetamp}} methods
returns the time un-adjusted instead of throwing an error:
> {code}
> hive> select from_utc_timestamp('2015-04-11 12:24:34.535', 'panda');
> OK
> 2015-04-11 12:24:34.535
> {code}
> This should be an error because users may attempt to adjust to valid but unknown zones,
like PDT or MDT. This would produce incorrect results with no warning or error.
> *Update*: A good work-around is to add a table of known zones that maps to offset zone
identifiers, like {{GMT-07:00}}. The table is small enough to always be a broadcast join and
results can be filtered (e.g. {{offset_zone IS NOT NULL}}) so that only valid zones are passed
to {{from_utc_timestamp}}.

This message was sent by Atlassian JIRA

View raw message