hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17371) Move tokenstores to metastore module
Date Mon, 16 Oct 2017 20:40:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206569#comment-16206569
] 

Hive QA commented on HIVE-17371:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12892436/HIVE-17371.05.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7327/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7327/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7327/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and
output '+ date '+%Y-%m-%d %T.%3N'
2017-10-16 20:39:12.652
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-7327/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2017-10-16 20:39:12.655
+ cd apache-github-source-source
+ git fetch origin
>From https://github.com/apache/hive
   031cfa2..599a74f  master     -> origin/master
+ git reset --hard HEAD
HEAD is now at 031cfa2 HIVE-17214 heck/fix conversion of unbucketed non-acid to acid (Eugene
Koifman, reviewed by Sergey Shelukhin)
+ git clean -f -d
Removing standalone-metastore/src/gen/org/
+ git checkout master
Already on 'master'
Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded.
  (use "git pull" to update your local branch)
+ git reset --hard origin/master
HEAD is now at 599a74f HIVE-17391 Compaction fails if there is an empty value in tblproperties
(Steve Yeom via Eugene Koifman)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2017-10-16 20:39:17.498
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch
Going to apply patch with: patch -p1
patching file beeline/src/test/org/apache/hive/beeline/ProxyAuthTest.java
patching file hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java
patching file hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/Security.java
patching file hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java
patching file itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHiveAuthFactory.java
patching file itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithDBTokenStore.java
patching file itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithMiniKdc.java
patching file itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/security/TestDBTokenStore.java
patching file itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/security/TestZooKeeperTokenStore.java
patching file itests/hive-unit/src/test/java/org/apache/hadoop/hive/thrift/TestDBTokenStore.java
patching file itests/hive-unit/src/test/java/org/apache/hadoop/hive/thrift/TestZooKeeperTokenStore.java
patching file jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
patching file jdbc/src/java/org/apache/hive/jdbc/Utils.java
patching file metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
patching file metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
patching file metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
patching file service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java
patching file service/src/java/org/apache/hive/service/auth/HttpAuthUtils.java
patching file service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java
patching file service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
patching file service/src/java/org/apache/hive/service/cli/session/SessionUtils.java
patching file shims/0.23/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge23.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/shims/Utils.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/thrift/DBTokenStore.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenIdentifier.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenSelector.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenStore.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/thrift/HiveDelegationTokenManager.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/thrift/MemoryTokenStore.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/thrift/TokenStoreDelegationTokenSecretManager.java
patching file shims/common/src/main/java/org/apache/hadoop/hive/thrift/ZooKeeperTokenStore.java
patching file standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/security/DBTokenStore.java
patching file standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/security/DelegationTokenSelector.java
patching file standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/security/DelegationTokenStore.java
patching file standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/security/MemoryTokenStore.java
patching file standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/security/MetastoreDelegationTokenManager.java
patching file standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/security/TokenStoreDelegationTokenSecretManager.java
patching file standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/security/ZooKeeperTokenStore.java
patching file standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/SecurityUtils.java
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven
protoc-jar: protoc version: 250, detected platform: linux/amd64
protoc-jar: executing: [/tmp/protoc5952598768341393905.exe, -I/data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/protobuf/org/apache/hadoop/hive/metastore,
--java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/target/generated-sources,
/data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto]
ANTLR Parser Generator  Version 3.5.2
Output file /data/hiveptest/working/apache-github-source-source/standalone-metastore/target/generated-sources/antlr3/org/apache/hadoop/hive/metastore/parser/FilterParser.java
does not exist: must build /data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g
org/apache/hadoop/hive/metastore/parser/Filter.g
[ERROR] COMPILATION ERROR : 
[ERROR] /data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/security/DBTokenStore.java:[94,18]
cannot find symbol
  symbol:   variable HiveDelegationTokenSupport
  location: class org.apache.hadoop.hive.metastore.security.DBTokenStore
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
(default-compile) on project hive-standalone-metastore: Compilation failure
[ERROR] /data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/security/DBTokenStore.java:[94,18]
cannot find symbol
[ERROR] symbol:   variable HiveDelegationTokenSupport
[ERROR] location: class org.apache.hadoop.hive.metastore.security.DBTokenStore
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following
articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hive-standalone-metastore
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12892436 - PreCommit-HIVE-Build

> Move tokenstores to metastore module
> ------------------------------------
>
>                 Key: HIVE-17371
>                 URL: https://issues.apache.org/jira/browse/HIVE-17371
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Metastore
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>         Attachments: HIVE-17371.01.patch, HIVE-17371.02.patch, HIVE-17371.03.patch, HIVE-17371.04.patch,
HIVE-17371.05.patch
>
>
> The {{getTokenStore}} method will not work for the {{DBTokenStore}} and {{ZKTokenStore}}
since they implement {{org.apache.hadoop.hive.thrift.DelegationTokenStore}} instead of  {{org.apache.hadoop.hive.metastore.security.DelegationTokenStore}}
> {code}
> private DelegationTokenStore getTokenStore(Configuration conf) throws IOException {
>     String tokenStoreClassName =
>         MetastoreConf.getVar(conf, MetastoreConf.ConfVars.DELEGATION_TOKEN_STORE_CLS,
"");
>     // The second half of this if is to catch cases where users are passing in a HiveConf
for
>     // configuration.  It will have set the default value of
>     // "hive.cluster.delegation.token.store .class" to
>     // "org.apache.hadoop.hive.thrift.MemoryTokenStore" as part of its construction.
 But this is
>     // the hive-shims version of the memory store.  We want to convert this to our default
value.
>     if (StringUtils.isBlank(tokenStoreClassName) ||
>         "org.apache.hadoop.hive.thrift.MemoryTokenStore".equals(tokenStoreClassName))
{
>       return new MemoryTokenStore();
>     }
>     try {
>       Class<? extends DelegationTokenStore> storeClass =
>           Class.forName(tokenStoreClassName).asSubclass(DelegationTokenStore.class);
>       return ReflectionUtils.newInstance(storeClass, conf);
>     } catch (ClassNotFoundException e) {
>       throw new IOException("Error initializing delegation token store: " + tokenStoreClassName,
e);
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message