hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vihang Karajgaonkar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17425) Change MetastoreConf.ConfVars internal members to be private
Date Tue, 17 Oct 2017 02:55:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206938#comment-16206938
] 

Vihang Karajgaonkar commented on HIVE-17425:
--------------------------------------------

I like the idea to discourage devs to use conf.get() and conf.set() methods directly. Can
we change the usage of the conf.get() and conf.set() usage in the patch? Eg. in Metrics.java
I see the following line {{String reportersToStart = conf.get(MetastoreConf.ConfVars.METRICS_REPORTERS.getVarname());}}
Is there a reason why we can't use {{MetastoreConf.get(conf, MetastoreConf.ConfVars.METRICS_REPORTERS)}}.
Same for the other places in the patch as well.



> Change MetastoreConf.ConfVars internal members to be private
> ------------------------------------------------------------
>
>                 Key: HIVE-17425
>                 URL: https://issues.apache.org/jira/browse/HIVE-17425
>             Project: Hive
>          Issue Type: Task
>          Components: Metastore
>    Affects Versions: 3.0.0
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: HIVE-17425.patch
>
>
> MetastoreConf's dual use of metastore keys and Hive keys is causing confusion for developers.
 We should make the relevant members private and provide getter methods with comments on when
it is appropriate to use them.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message