hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <>
Subject [jira] [Commented] (HIVE-18153) refactor reopen and file management in TezTask
Date Sat, 09 Dec 2017 03:57:02 GMT


Hive QA commented on HIVE-18153:

Here are the results of testing the latest attachment:

{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 11514 tests executed
*Failed tests:*
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=160)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] (batchId=113)
org.apache.hadoop.hive.ql.exec.tez.TestTezSessionPool.testCloseAndOpenDefault (batchId=285)
org.apache.hadoop.hive.ql.exec.tez.TestTezSessionPool.testSessionReopen (batchId=285)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=226)

Test results:
Console output:
Test logs:

Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed

This message is automatically generated.

ATTACHMENT ID: 12901266 - PreCommit-HIVE-Build

> refactor reopen and file management in TezTask
> ----------------------------------------------
>                 Key: HIVE-18153
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-18153.01.patch, HIVE-18153.02.patch, HIVE-18153.03.patch, HIVE-18153.patch
> TezTask reopen relies on getting the same session object in terms of setup; WM reopen
returns a new session from the pool. 
> The former has the advantage of not having to reupload files and stuff... but the object
reuse results in a lot of ugly code, and also reopen might be slower on average with the session
pool than just getting a session from the pool. Either WM needs to do the object-preserving
reopen, or TezTask needs to be refactored. It looks like DAG would have to be rebuilt to do
the latter because of some paths tied to a directory of the old session. Let me see if I can
get around that; if not we can do the former; and then if the former results in too much ugly
code in WM to account for object reuse for different Tez client I'd do the latter anyway since
it's a failure path :)

This message was sent by Atlassian JIRA

View raw message