hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-18222) Update checkstyle rules to be less peeky
Date Tue, 05 Dec 2017 09:21:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-18222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Zoltan Haindrich updated HIVE-18222:
------------------------------------
    Attachment: HIVE-18222.01.patch

> Update checkstyle rules to be less peeky
> ----------------------------------------
>
>                 Key: HIVE-18222
>                 URL: https://issues.apache.org/jira/browse/HIVE-18222
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-18222.01.patch
>
>
> there are a few issues with the current checkstyle.xml
> as long as the new checks are coming back red all the time; people will start to ignore
these checks...so I think, it would be better to make the checks less strict...
> * set max linelength to 140; it looks like a more natural limit - because there are classnames
which are eating up line space pretty quickly... like: {{PrimitiveObjectInspector}} :) 
> * make checkstyle.xml easily importable into ide (use {{config_loc}} instead {{basedir}})
> * suppress generated vectorized class errors



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message