hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Vary (JIRA)" <>
Subject [jira] [Commented] (HIVE-18222) Update checkstyle rules to be less peeky
Date Tue, 05 Dec 2017 11:36:00 GMT


Peter Vary commented on HIVE-18222:

[~kgyrtkirk]: Could you please check that yetus runs with the new checkstyle? I do not think
there should be any problems, but a manual run should be easy to do.

Also: Is it ok if we change the max line length without a discuss thread? I am all for it,
but did not want to change it myself before :)

> Update checkstyle rules to be less peeky
> ----------------------------------------
>                 Key: HIVE-18222
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-18222.01.patch
> there are a few issues with the current checkstyle.xml
> as long as the new checks are coming back red all the time; people will start to ignore
these I think, it would be better to make the checks less strict...
> * set max linelength to 140; it looks like a more natural limit - because there are classnames
which are eating up line space pretty quickly... like: {{PrimitiveObjectInspector}} :) 
> * make checkstyle.xml easily importable into ide (use {{config_loc}} instead {{basedir}})
> * suppress generated vectorized class errors

This message was sent by Atlassian JIRA

View raw message