hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18343) Remove LinkedList from ColumnStatsSemanticAnalyzer.java
Date Wed, 27 Dec 2017 17:58:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304713#comment-16304713
] 

BELUGA BEHR commented on HIVE-18343:
------------------------------------

{code}
./ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java:99:       
List<String> colName = new ArrayList<String>(numCols);: warning: 'block' child
have incorrect indentation level 8, expected level should be 6.
./ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java:99:       
List<String> colName = new ArrayList<String>(numCols);: warning: 'member def type'
have incorrect indentation level 8, expected level should be 6.
{code}

> Remove LinkedList from ColumnStatsSemanticAnalyzer.java
> -------------------------------------------------------
>
>                 Key: HIVE-18343
>                 URL: https://issues.apache.org/jira/browse/HIVE-18343
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: HIVE-18343.1.patch
>
>
> Remove {{LinkedList}} in favor of {{ArrayList}} for class {{org.apache.hadoop.hive.ql.parse.ColumnStatsSemanticAnalyzer}}.
> {quote}
> The size, isEmpty, get, set, iterator, and listIterator operations run in constant time.
The add operation runs in amortized constant time, that is, adding n elements requires O\(n\)
time. All of the other operations run in linear time (roughly speaking). *The constant factor
is low compared to that for the LinkedList implementation.*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message