hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18766) Race condition during shutdown of RemoteDriver, error messages aren't always sent
Date Wed, 06 Jun 2018 19:06:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503753#comment-16503753
] 

Hive QA commented on HIVE-18766:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12926636/HIVE-18766.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14467 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11564/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11564/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11564/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12926636 - PreCommit-HIVE-Build

> Race condition during shutdown of RemoteDriver, error messages aren't always sent
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-18766
>                 URL: https://issues.apache.org/jira/browse/HIVE-18766
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>            Reporter: Sahil Takiar
>            Assignee: Aihua Xu
>            Priority: Major
>         Attachments: HIVE-18766.1.patch, HIVE-18766.2.patch
>
>
> When we send an error during shutdown of the {{RemoteDriver}}, we don't wait for the
error message to be sent. We just send it and then close the RPC channel. For a graceful shutdown,
that doesn't seem ideal. We should at least wait a bit for the RPC message to be sent before
shutting things down. I ran some tests locally and its pretty easy to hit a situation where
the error message doesn't even get sent to the {{SparkClientImpl}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message