hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-19718) Adding partitions in bulk also fetches table for each partition
Date Wed, 06 Jun 2018 11:35:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-19718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503166#comment-16503166
] 

Hive QA commented on HIVE-19718:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 35s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 16s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 54s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 31s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  2m 31s{color} | {color:blue}
standalone-metastore in master has 214 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 56s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  8s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 16s{color} | {color:red}
hcatalog-unit in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 52s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 52s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 21s{color} | {color:red}
standalone-metastore: The patch generated 2 new + 963 unchanged - 2 fixed = 965 total (was
965) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 37s{color} |
{color:green} standalone-metastore generated 0 new + 213 unchanged - 1 fixed = 213 total (was
214) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 57s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 11s{color} | {color:red}
The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 26s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11555/dev-support/hive-personality.sh
|
| git revision | master / 0992d82 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-11555/yetus/patch-mvninstall-itests_hcatalog-unit.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-11555/yetus/diff-checkstyle-standalone-metastore.txt
|
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-11555/yetus/patch-asflicense-problems.txt
|
| modules | C: itests/hcatalog-unit standalone-metastore U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11555/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Adding partitions in bulk also fetches table for each partition
> ---------------------------------------------------------------
>
>                 Key: HIVE-19718
>                 URL: https://issues.apache.org/jira/browse/HIVE-19718
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 3.0.0
>         Environment: Looking at {{convertToMPart}}:
> {code:Java}
>   private MPartition convertToMPart(Partition part, boolean useTableCD)
>       throws InvalidObjectException, MetaException {
>     MTable mt = getMTable(part.getCatName(), part.getDbName(), part.getTableName());
>     ...
> {code}
> So what we have as a result is that we fetch table for every partition where it should
be done just once.
>            Reporter: Alexander Kolbasov
>            Assignee: Peter Vary
>            Priority: Major
>         Attachments: HIVE-19718.2.patch, HIVE-19718.3.patch, HIVE-19718.4.patch, HIVE-19718.5.patch,
HIVE-19718.patch
>
>
> The ObjectStore.addPartitions() method does this:
> {code:java}
> for (Partition part : parts) {
>   if (!part.getTableName().equals(tblName) || !part.getDbName().equals(dbName)) {
>     throw new MetaException("Partition does not belong to target table "
>         + dbName + "." + tblName + ": " + part);
>   }
>   MPartition mpart = convertToMPart(part, true); // <-- Here
>   toPersist.add(mpart);
>   ...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message