hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-19886) Logs may be directed to 2 files if --hiveconf hive.log.file is used
Date Mon, 18 Jun 2018 16:56:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516011#comment-16516011
] 

ASF GitHub Bot commented on HIVE-19886:
---------------------------------------

GitHub user beltran opened a pull request:

    https://github.com/apache/hive/pull/375

    HIVE-19886: Logs may be directed to 2 files if --hiveconf hive.log.fi…

    …le is used.
    
    This is still dumping some logs for the metastore before the reconfiguration is done:
    ```
    2018-06-18T16:39:17,109  INFO [main] conf.MetastoreConf: Found configuration file file:/hadoop-3.1.0/etc/hadoop/hive-site.xml
    2018-06-18T16:39:17,364  INFO [main] conf.MetastoreConf: Unable to find config file hivemetastore-site.xml
    2018-06-18T16:39:17,364  INFO [main] conf.MetastoreConf: Found configuration file null
    2018-06-18T16:39:17,365  INFO [main] conf.MetastoreConf: Unable to find config file metastore-site.xml
    2018-06-18T16:39:17,365  INFO [main] conf.MetastoreConf: Found configuration file null
    ```
    (and that's it). Before, the loggers created before the logging configuration happened
sent the logs to the wrong file forever.
    
    It's hard to get rid of those because `MetastoreConf` is used to create the configure
logging(and therefore spits logs before the configuration happens) so some refactoring would
have to be done.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/beltran/hive HIVE-19886

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hive/pull/375.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #375
    
----
commit a4b0fbff76ff912823e912b7f2104fbd7db88116
Author: Jaume Marhuenda <jaumemarhuenda@...>
Date:   2018-06-18T16:44:13Z

    HIVE-19886: Logs may be directed to 2 files if --hiveconf hive.log.file is used

----


> Logs may be directed to 2 files if --hiveconf hive.log.file is used
> -------------------------------------------------------------------
>
>                 Key: HIVE-19886
>                 URL: https://issues.apache.org/jira/browse/HIVE-19886
>             Project: Hive
>          Issue Type: Bug
>          Components: Logging
>    Affects Versions: 3.1.0, 4.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Jaume M
>            Priority: Major
>              Labels: pull-request-available
>
> hive launch script explicitly specific log4j2 configuration file to use. The main() methods
in HiveServer2 and HiveMetastore reconfigures the logger based on user input via --hiveconf
hive.log.file. This may cause logs to end up in 2 different files. Initial logs goes to the
file specified in hive-log4j2.properties and after logger reconfiguration the rest of the
logs goes to the file specified via --hiveconf hive.log.file. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message