hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-19916) master-txnstats branch - integrate with HIVE-19382
Date Mon, 18 Jun 2018 20:23:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-19916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516311#comment-16516311
] 

Sergey Shelukhin commented on HIVE-19916:
-----------------------------------------

Discussed in person, basically it should never go to metastore, we should just remove that
code. If stats are available it should work, otherwise fail.
If we see it fails, some extra work might be needed to use writeId-s that are added to conf
by code from HIVE-19382 before optmizers.
Basically we should use those IDs because they are checked later after lock acquisition for
consistency; the ones we may get from metastore on some random code branch will not be (also
it's an extra call to metastore we can avoid).

> master-txnstats branch - integrate with HIVE-19382
> --------------------------------------------------
>
>                 Key: HIVE-19916
>                 URL: https://issues.apache.org/jira/browse/HIVE-19916
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Steve Yeom
>            Priority: Major
>
> There's some code in original txn stats patch that may go to metastore to get write Ids.
This code should not go to metastore, it should fail instead. 
> HIVE-19382 should ensure that we have correct IDs already present during optimizer -
they are using by e.g. materialized view optimizer, so they should be there; if they are not
present, some integration might be needed so that txn stats optimizations also have access
to those write Ids.
> cc [~jcamachorodriguez]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message