hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ferdinand Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-17593) DataWritableWriter strip spaces for CHAR type before writing, but predicate generator doesn't do same thing.
Date Wed, 04 Jul 2018 01:40:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-17593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532134#comment-16532134
] 

Ferdinand Xu commented on HIVE-17593:
-------------------------------------

Is this diff caused by padding?
{code:java}
214,217c214,217
< a     1 a   3 48.88 1
< ab    2 ab  3 8.72 1
< abc   3 abc 3 90.21 1
< abcd  4 abcd 4 3.89 1
---
> a     5 a   3 48.88 1
> ab    5 ab  3 8.72 1
> abc   5 abc 3 90.21 1
> abcd  5 abcd 4 3.89 1
555,558c555,558
< a     1 a   3 48.88 1
< ab    2 ab  3 8.72 1
< abc   3 abc 3 90.21 1
< abcd  4 abcd 4 3.89 1
---
> a     5 a   3 48.88 1
> ab    5 ab  3 8.72 1
> abc   5 abc 3 90.21 1
> abcd  5 abcd 4 3.89 1
{code}


> DataWritableWriter strip spaces for CHAR type before writing, but predicate generator
doesn't do same thing.
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-17593
>                 URL: https://issues.apache.org/jira/browse/HIVE-17593
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.3.0, 3.0.0
>            Reporter: Junjie Chen
>            Assignee: Junjie Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.1.0
>
>         Attachments: HIVE-17593.2.patch, HIVE-17593.3.patch, HIVE-17593.patch
>
>
> DataWritableWriter strip spaces for CHAR type before writing. While when generating predicate,
it does NOT do same striping which should cause data missing!
> In current version, it doesn't cause data missing since predicate is not well push down
to parquet due to HIVE-17261.
> Please see ConvertAstTosearchArg.java, getTypes treats CHAR and STRING as same which
will build a predicate with tail spaces.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message