hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vineet Garg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18852) Misleading error message in alter table validation
Date Tue, 24 Jul 2018 18:58:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554673#comment-16554673
] 

Vineet Garg commented on HIVE-18852:
------------------------------------

[~asherman] I am unable to apply this patch to master.
{code:bash}
$ sh ./testutils/ptest2/src/main/resources/smart-apply-patch.sh /tmp/HIVE-18852.1.patch
error: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:
does not exist in index
error: src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java: does not exist
in index
error: main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java: does not exist in
index
The patch does not appear to apply with p0, p1, or p2
{code}

Can you rebase and reupload the patch?

> Misleading error message in alter table validation
> --------------------------------------------------
>
>                 Key: HIVE-18852
>                 URL: https://issues.apache.org/jira/browse/HIVE-18852
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 2.4.0
>            Reporter: Dan Burkert
>            Assignee: Andrew Sherman
>            Priority: Major
>         Attachments: HIVE-18852.1.patch
>
>
> The metastore's validation error message when attempting to rename a table to a non-existent
database is wrong.  For instance, attempting to alter table 'db.table' to 'non_existent_database.table'
results in the Thrift error:
> {{TException - service has thrown: InvalidOperationException(message=Unable to change
partition or table. Database db does not exist Check metastore logs for detailed stack.non_existent_database)}}
> I believe the offending line of code is [here|https://github.com/apache/hive/blob/branch-2/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java?utf8=%E2%9C%93#L331-L333],
notice that {{dbname}} is used in the message, not {{newDbName}}.  I don't know if switching
that would cause the case of a non-existing {{dbname}} case to regress, though.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message