hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18929) The method humanReadableInt in HiveStringUtils.java has a race condition.
Date Sun, 01 Jul 2018 02:28:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528960#comment-16528960
] 

Hive QA commented on HIVE-18929:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12929647/HIVE-18929.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14635 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12289/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12289/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12289/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12929647 - PreCommit-HIVE-Build

> The method humanReadableInt in HiveStringUtils.java has a race condition.
> -------------------------------------------------------------------------
>
>                 Key: HIVE-18929
>                 URL: https://issues.apache.org/jira/browse/HIVE-18929
>             Project: Hive
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 2.3.2
>            Reporter: Chaiyong Ragkhitwetsagul
>            Assignee: Andrew Sherman
>            Priority: Minor
>         Attachments: HIVE-18929.1.patch
>
>
> I found that the {{humanReadableInt(long number)}} method in the hive/common/src/java/org/apache/hive/common/util/HiveStringUtils.java
file contains code which has a race condition as shown in Hadoop (issue tracking ID HADOOP-9252:
https://issues.apache.org/jira/browse/HADOOP-9252). The fix can also be seen in the Hadoop
code base.
> I couldn't find a call to the method anywhere else in the code. But it might be worth
to fix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message