hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20030) Fix Java compile errors that show up in IntelliJ from ConvertJoinMapJoin.java and AnnotateRunTimeStatsOptimizer.java
Date Sun, 01 Jul 2018 00:41:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528946#comment-16528946
] 

Hive QA commented on HIVE-20030:
--------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 38s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  2s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 37s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 50s{color} | {color:blue}
ql in master has 2287 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 55s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 23s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  2s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  2s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 37s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  5s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 53s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 12s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 43s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12288/dev-support/hive-personality.sh
|
| git revision | master / 6acd74c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12288/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Fix Java compile errors that show up in IntelliJ from ConvertJoinMapJoin.java and AnnotateRunTimeStatsOptimizer.java
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-20030
>                 URL: https://issues.apache.org/jira/browse/HIVE-20030
>             Project: Hive
>          Issue Type: Task
>            Reporter: Andrew Sherman
>            Assignee: Andrew Sherman
>            Priority: Major
>         Attachments: HIVE-20030.1.patch
>
>
> For some reason the Java compiler in IntellJ is more strict that the Oracle jdk compiler.
Maybe this is something that can be configured away, but as it is simple I propose to make
the code more type correct. 
> {code}
> /Users/asherman/git/asf/hive2/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
> Error:(613, 24) java: no suitable method found for findOperatorsUpstream(java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>,java.lang.Class<org.apache.hadoop.hive.ql.exec.ReduceSinkOperator>)
>     method org.apache.hadoop.hive.ql.exec.OperatorUtils.<T>findOperatorsUpstream(org.apache.hadoop.hive.ql.exec.Operator<?>,java.lang.Class<T>)
is not applicable
>       (cannot infer type-variable(s) T
>         (argument mismatch; java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>> cannot be converted to org.apache.hadoop.hive.ql.exec.Operator<?>))
>     method org.apache.hadoop.hive.ql.exec.OperatorUtils.<T>findOperatorsUpstream(java.util.Collection<org.apache.hadoop.hive.ql.exec.Operator<?>>,java.lang.Class<T>)
is not applicable
>       (cannot infer type-variable(s) T
>         (argument mismatch; java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>> cannot be converted to java.util.Collection<org.apache.hadoop.hive.ql.exec.Operator<?>>))
>     method org.apache.hadoop.hive.ql.exec.OperatorUtils.<T>findOperatorsUpstream(org.apache.hadoop.hive.ql.exec.Operator<?>,java.lang.Class<T>,java.util.Set<T>)
is not applicable
>       (cannot infer type-variable(s) T
>         (actual and formal argument lists differ in length))
> {code}
> and
> {code}
> /Users/asherman/git/asf/hive2/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AnnotateRunTimeStatsOptimizer.java
> Error:(76, 12) java: no suitable method found for addAll(java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?>>)
>     method java.util.Collection.addAll(java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
>       (argument mismatch; java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?>>
cannot be converted to java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
>     method java.util.Set.addAll(java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
>       (argument mismatch; java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?>>
cannot be converted to java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
> Error:(80, 14) java: no suitable method found for addAll(java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>>)
>     method java.util.Collection.addAll(java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
>       (argument mismatch; java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>>
cannot be converted to java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
>     method java.util.Set.addAll(java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
>       (argument mismatch; java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>>
cannot be converted to java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
> Error:(85, 14) java: no suitable method found for addAll(java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>>)
>     method java.util.Collection.addAll(java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
>       (argument mismatch; java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>>
cannot be converted to java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
>     method java.util.Set.addAll(java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>) is not applicable
>       (argument mismatch; java.util.Set<org.apache.hadoop.hive.ql.exec.Operator<?>>
cannot be converted to java.util.Collection<? extends org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>)
> /Users/asherman/git/asf/hive2/ql/target/generated-sources/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/IntervalYearMonthScalarAddTimestampColumn.java
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message