hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20177) Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode
Date Sun, 15 Jul 2018 10:01:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544509#comment-16544509
] 

Hive QA commented on HIVE-20177:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  1s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 34s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  7s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 40s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 12s{color} | {color:blue}
ql in master has 2291 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  0s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 28s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  7s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  7s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 40s{color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 14s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  0s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 44s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12623/dev-support/hive-personality.sh
|
| git revision | master / 1b5903b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-12623/yetus/whitespace-eol.txt
|
| modules | C: ql U: ql |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12623/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode
> ---------------------------------------------------------------------
>
>                 Key: HIVE-20177
>                 URL: https://issues.apache.org/jira/browse/HIVE-20177
>             Project: Hive
>          Issue Type: Bug
>          Components: Vectorization
>            Reporter: Gopal V
>            Assignee: Gopal V
>            Priority: Major
>         Attachments: HIVE-20177.WIP.patch
>
>
> The streaming mode for VectorGroupBy allocates a large number of arrays due to VectorKeyHashWrapper::duplicateTo()
> Since the vectors can't be mutated in-place while a single batch is being processed,
this operation can be cut by 1000x by allocating a streaming key at the end of the loop, instead
of reallocating within the loop.
> {code}
>       for(int i = 0; i < batch.size; ++i) {
>         if (!batchKeys[i].equals(streamingKey)) {
>           // We've encountered a new key, must save current one
>           // We can't forward yet, the aggregators have not been evaluated
>           rowsToFlush[flushMark] = currentStreamingAggregators;
>           if (keysToFlush[flushMark] == null) {
>             keysToFlush[flushMark] = (VectorHashKeyWrapper) streamingKey.copyKey();
>           } else {
>             streamingKey.duplicateTo(keysToFlush[flushMark]);
>           }
>           currentStreamingAggregators = streamAggregationBufferRowPool.getFromPool();
>           batchKeys[i].duplicateTo(streamingKey);
>           ++flushMark;
>         }
> {code}
> The duplicateTo can be pushed out of the loop since there only one to truly keep a copy
of is the last unique key in the VRB.
> The actual byte[] values within the keys are safely copied out by - VectorHashKeyWrapperBatch.assignRowColumn()
which calls setVal() and not setRef().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message