hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (HIVE-20257) Improvements to Hive.java
Date Fri, 27 Jul 2018 18:45:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-20257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

BELUGA BEHR reassigned HIVE-20257:
----------------------------------

    Assignee: BELUGA BEHR

> Improvements to Hive.java
> -------------------------
>
>                 Key: HIVE-20257
>                 URL: https://issues.apache.org/jira/browse/HIVE-20257
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>             Fix For: 4.0.0
>
>         Attachments: HIVE-20257.1.patch
>
>
> Various fixes to {{Hive.java}}
>  * Use Log4J parameters in logging statements
>  * Fix check styles
>  * Make code more concise
>  * Remove "log and throw" code
>  * Replaced calls to deprecated code
>  * Removed superfluous calls to {{toString}}
>  
> "log and throw" is considered and anti-pattern.  Only the highest level catch should
be providing detailed logging otherwise we print the same stack trace to the logs several
times and with different context (for example when an exception is wrapped, we get two different
logging events).
>  
> https://community.oracle.com/docs/DOC-983543#logAndThrow



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message