hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koifman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18453) ACID: Add "CREATE TRANSACTIONAL TABLE" syntax to unify ACID ORC & Parquet support
Date Tue, 21 Aug 2018 17:58:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587805#comment-16587805
] 

Eugene Koifman commented on HIVE-18453:
---------------------------------------

[~ikryvenko], the build bot didn't pick up patch 6 and it doesn't compile for me.
The output of describe table commands in create_transactional.q.out doesn't show transactional=true
table property anywhere - I don't think you are actually creating transactional tables.  Instead
of testing various select statements (which I think would already be covered elsewhere), I
would add some update/delete commands - the system will throw exceptions if the table is not
transactional.

{{MetastoreConf.CREATE_TABLES_AS_ACID}} is a global config prop. If it's true, then any Create
Table statement is examined and if the table can be made transactional=true, it will be made
so, w/o the user explicitly specifying transactional=true.
{{HiveConf.HIVE_CREATE_TABLES_AS_INSERT_ONLY}} works similarly.  If it's true, the system
will make a Create Table stmt create a table with {{tblproperties ("transactional"="true",
"transactional_properties"="insert_only")}}.  I just meant it may be useful to look at where
they are referenced in {{SemanticAnalyzer}} to help with your implementation.

Basically, {{create transactional table....}} should just be syntactic sugar for {{create
table p.... tblproperties ("transactional"="true")}}

> ACID: Add "CREATE TRANSACTIONAL TABLE" syntax to unify ACID ORC & Parquet support
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-18453
>                 URL: https://issues.apache.org/jira/browse/HIVE-18453
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>            Reporter: Gopal V
>            Assignee: Igor Kryvenko
>            Priority: Major
>         Attachments: HIVE-18453.01.patch, HIVE-18453.02.patch, HIVE-18453.03.patch, HIVE-18453.04.patch,
HIVE-18453.05.patch, HIVE-18453.06.patch
>
>
> The ACID table markers are currently done with TBLPROPERTIES which is inherently fragile.
> The "create transactional table" offers a way to standardize the syntax and allows for
future compatibility changes to support Parquet ACIDv2 tables along with ORC tables.
> The ACIDv2 design is format independent, with the ability to add new vectorized input
formats with no changes to the design.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message