hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Voros (JIRA)" <>
Subject [jira] [Commented] (HIVE-20191) PreCommit patch application doesn't fail if patch is empty
Date Tue, 21 Aug 2018 15:58:00 GMT


Daniel Voros commented on HIVE-20191:

[~vihangk1], [~kgyrtkirk] this is what we've discussed on the dev list earlier. If you could
take a look that would be much appreciated!

> PreCommit patch application doesn't fail if patch is empty
> ----------------------------------------------------------
>                 Key: HIVE-20191
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Testing Infrastructure
>            Reporter: Daniel Voros
>            Assignee: Daniel Voros
>            Priority: Major
>         Attachments: HIVE-20191.1.patch
> I've created some backport tickets to branch-3 (e.g. HIVE-20181) and made the mistake
of uploading the patch files with wrong filename ({{.}} instead of {{-}} between version and
> These get applied on master, where they're already present, since {{git apply}} with
{{-3}} won't fail if patch is already there. Tests are run on master instead of failing.
> I think the patch application should fail if the patch is empty and branch selection
logic should probably fail too if the patch name is malformed.

This message was sent by Atlassian JIRA

View raw message