hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aihua Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20237) Do Not Print StackTraces to STDERR in HiveMetaStore
Date Fri, 17 Aug 2018 21:52:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584427#comment-16584427
] 

Aihua Xu commented on HIVE-20237:
---------------------------------

It's good to remove that so we don't print duplicated error stack trace. +1.

> Do Not Print StackTraces to STDERR in HiveMetaStore
> ---------------------------------------------------
>
>                 Key: HIVE-20237
>                 URL: https://issues.apache.org/jira/browse/HIVE-20237
>             Project: Hive
>          Issue Type: Improvement
>          Components: Standalone Metastore
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: Alice Fan
>            Priority: Trivial
>              Labels: newbie, noob
>         Attachments: HIVE-20237.1.patch, HIVE-20237.2.patch
>
>
> {code:java|title=HiveMetaStore.java}
>     } catch (Throwable x) {
>       x.printStackTrace();
>       HMSHandler.LOG.error(StringUtils.stringifyException(x));
>       throw x;
>     }
> {code}
> Bad design here of "log and throw".  Don't do it.  Just throw the exception and let it
be handled, and logged, in one place.  At the very least, we don't need the error message
to go into the STDERR logs with {{printStackTrace}}, please remove.  And remove the {{stringifyException}}
code.  Just use the normal logging faciltiies at the 'debug' level logging to hide the stack
trace during normal operations.
> {code}
> HMSHandler.LOG.debug("Error", e);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message