hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20237) Do Not Print StackTraces to STDERR in HiveMetaStore
Date Wed, 15 Aug 2018 15:25:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581229#comment-16581229
] 

Hive QA commented on HIVE-20237:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 18s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 26s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m  8s{color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 15s{color} | {color:red}
metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 23s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 33s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 28s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 28s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m  9s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 14s{color} | {color:red}
metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 24s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 14s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 53s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13238/dev-support/hive-personality.sh
|
| git revision | master / 691e654 |
| Default Java | 1.8.0_111 |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13238/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13238/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
|
| modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server
|
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13238/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Do Not Print StackTraces to STDERR in HiveMetaStore
> ---------------------------------------------------
>
>                 Key: HIVE-20237
>                 URL: https://issues.apache.org/jira/browse/HIVE-20237
>             Project: Hive
>          Issue Type: Improvement
>          Components: Standalone Metastore
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: Alice Fan
>            Priority: Trivial
>              Labels: newbie, noob
>         Attachments: HIVE-20237.1.patch
>
>
> {code:java|title=HiveMetaStore.java}
>     } catch (Throwable x) {
>       x.printStackTrace();
>       HMSHandler.LOG.error(StringUtils.stringifyException(x));
>       throw x;
>     }
> {code}
> Bad design here of "log and throw".  Don't do it.  Just throw the exception and let it
be handled, and logged, in one place.  At the very least, we don't need the error message
to go into the STDERR logs with {{printStackTrace}}, please remove.  And remove the {{stringifyException}}
code.  Just use the normal logging faciltiies at the 'debug' level logging to hide the stack
trace during normal operations.
> {code}
> HMSHandler.LOG.debug("Error", e);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message