hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20237) Do Not Print StackTraces to STDERR in HiveMetaStore
Date Wed, 15 Aug 2018 16:13:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581294#comment-16581294
] 

Hive QA commented on HIVE-20237:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12935645/HIVE-20237.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14879 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13238/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13238/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13238/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12935645 - PreCommit-HIVE-Build

> Do Not Print StackTraces to STDERR in HiveMetaStore
> ---------------------------------------------------
>
>                 Key: HIVE-20237
>                 URL: https://issues.apache.org/jira/browse/HIVE-20237
>             Project: Hive
>          Issue Type: Improvement
>          Components: Standalone Metastore
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: Alice Fan
>            Priority: Trivial
>              Labels: newbie, noob
>         Attachments: HIVE-20237.1.patch
>
>
> {code:java|title=HiveMetaStore.java}
>     } catch (Throwable x) {
>       x.printStackTrace();
>       HMSHandler.LOG.error(StringUtils.stringifyException(x));
>       throw x;
>     }
> {code}
> Bad design here of "log and throw".  Don't do it.  Just throw the exception and let it
be handled, and logged, in one place.  At the very least, we don't need the error message
to go into the STDERR logs with {{printStackTrace}}, please remove.  And remove the {{stringifyException}}
code.  Just use the normal logging faciltiies at the 'debug' level logging to hide the stack
trace during normal operations.
> {code}
> HMSHandler.LOG.debug("Error", e);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message