hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20296) Improve HivePointLookupOptimizerRule to be able to extract from more sophisticated contexts
Date Fri, 24 Aug 2018 05:43:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591175#comment-16591175
] 

Hive QA commented on HIVE-20296:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 13s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  5s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 41s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  6s{color} | {color:blue}
ql in master has 2308 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  3s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 27s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  6s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  6s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 39s{color} | {color:red}
ql: The patch generated 9 new + 91 unchanged - 27 fixed = 100 total (was 118) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 19s{color} | {color:red}
ql generated 2 new + 2308 unchanged - 0 fixed = 2310 total (was 2308) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 56s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 15s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 20s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Dead store to columnConstantsMap in org.apache.hadoop.hive.ql.optimizer.calcite.rules.HivePointLookupOptimizerRule$RexTransformIntoInClause.transformIntoInClauseCondition(RexBuilder,
RelDataType, RexNode, int)  At HivePointLookupOptimizerRule.java:org.apache.hadoop.hive.ql.optimizer.calcite.rules.HivePointLookupOptimizerRule$RexTransformIntoInClause.transformIntoInClauseCondition(RexBuilder,
RelDataType, RexNode, int)  At HivePointLookupOptimizerRule.java:[line 421] |
|  |  a must be non-null but is marked as nullable  At HivePointLookupOptimizerRule.java:is
marked as nullable  At HivePointLookupOptimizerRule.java:[lines 269-272] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13434/dev-support/hive-personality.sh
|
| git revision | master / 611770d |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13434/yetus/diff-checkstyle-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13434/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13434/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Improve HivePointLookupOptimizerRule to be able to extract from more sophisticated contexts
> -------------------------------------------------------------------------------------------
>
>                 Key: HIVE-20296
>                 URL: https://issues.apache.org/jira/browse/HIVE-20296
>             Project: Hive
>          Issue Type: Improvement
>          Components: Logical Optimizer
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>         Attachments: HIVE-20296.01wip01.patch
>
>
> Currently it could handle conditions in the form:
> {code}
> ( ( a=1 && b=1 && ... ) || (a=2 && b=2 && ...) || ...
)
> {code}
> If there is some noise somewhere in the or like: 
> {code}
> ( x=18 || ( a=1 && b=1 && ... ) || (a=2 && b=2 && ...)
|| ... )
> {code}
> it stops processing.
> https://github.com/apache/hive/blob/2cabb8da150b8fb980223fbd6c2c93b842ca3ee5/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java#L238
> HIVE-19097 right now unwinds some ors which can't be packed back; like query15
> https://github.com/apache/hive/blob/2cabb8da150b8fb980223fbd6c2c93b842ca3ee5/ql/src/test/queries/clientpositive/perf/query15.q#L14



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message