hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20315) Vectorization: Fix more NULL / Wrong Results issues and avoid unnecessary casts/conversions
Date Mon, 06 Aug 2018 00:58:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569624#comment-16569624
] 

Hive QA commented on HIVE-20315:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 33s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 16s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m  6s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 42s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 43s{color} | {color:blue}
serde in master has 195 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 24s{color} | {color:blue}
ql in master has 2301 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 26s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  8s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 28s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 38s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  7m 38s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 14s{color} | {color:red}
serde: The patch generated 2 new + 6 unchanged - 0 fixed = 8 total (was 6) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 24s{color} | {color:red}
root: The patch generated 2 new + 9 unchanged - 0 fixed = 11 total (was 9) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  3s{color} | {color:red}
ql: The patch generated 74 new + 1611 unchanged - 79 fixed = 1685 total (was 1690) {color}
|
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  2s{color} | {color:red}
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 12s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 12s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 12s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 21s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13050/dev-support/hive-personality.sh
|
| git revision | master / df5caa0 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13050/yetus/diff-checkstyle-serde.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13050/yetus/diff-checkstyle-root.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13050/yetus/diff-checkstyle-ql.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13050/yetus/whitespace-eol.txt
|
| modules | C: serde . ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13050/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Vectorization: Fix more NULL / Wrong Results issues and avoid unnecessary casts/conversions
> -------------------------------------------------------------------------------------------
>
>                 Key: HIVE-20315
>                 URL: https://issues.apache.org/jira/browse/HIVE-20315
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Critical
>         Attachments: HIVE-20315.01.patch, HIVE-20315.02.patch, HIVE-20315.03.patch, HIVE-20315.04.patch
>
>
> Generate multi-byte Unicode characters in addition to regular single byte characters
for random data.
> Don't CAST from STRING/VARCHAR/CHAR TO STRING since all are stored in vectorization without
padding.
> Fix vectorized BETWEEN expression work to avoid unnecessary CAST of DECIMAL constants.
> Fix NULL / Wrong Results issues in VectorElt.
> Change performance Q files to generate non-user EXPLAIN with VECTORIZATION display so
unnecesary CAST / DECIMAL_64 conversions are visible.
> Add test for vectorized STRUCT field reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message