hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20368) Remove VectorTopNKeyOperator lock
Date Fri, 17 Aug 2018 20:12:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584337#comment-16584337
] 

Hive QA commented on HIVE-20368:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m 13s{color} | {color:red}
/data/hiveptest/logs/PreCommit-HIVE-Build-13307/patches/PreCommit-HIVE-Build-13307.patch does
not apply to master. Rebase required? Wrong Branch? See http://cwiki.apache.org/confluence/display/Hive/HowToContribute
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13307/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Remove VectorTopNKeyOperator lock
> ---------------------------------
>
>                 Key: HIVE-20368
>                 URL: https://issues.apache.org/jira/browse/HIVE-20368
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Teddy Choi
>            Assignee: Teddy Choi
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0, 3.2.0
>
>         Attachments: HIVE-20368.1.patch, HIVE-20368.2.patch, HIVE-20368.2.patch
>
>
> VectorTopNKeyOperator has a lock in line 199 as following.
> {code:java}
> priorityQueue.offer(WritableUtils.clone(keysWritable, getConfiguration()));
> {code}
> WritableUtils.clone calls Confgiruation.getClassByNameOrNull that has synchronized block.
So it needs to run without locks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message