hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20388) Move common classes out of metastore-server
Date Sat, 25 Aug 2018 02:46:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592400#comment-16592400
] 

Hive QA commented on HIVE-20388:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 32s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 58s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 27s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m  9s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  2m 26s{color} | {color:blue}
standalone-metastore/metastore-common in master has 9 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  6s{color} | {color:blue}
ql in master has 2309 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 38s{color} | {color:blue}
service in master has 48 extant Findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 14s{color} | {color:red}
metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 27s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 11s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 23s{color} | {color:red}
service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 23s{color} | {color:red}
service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 23s{color} | {color:red}
service in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m  7s{color}
| {color:green} The patch metastore-common passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 39s{color}
| {color:green} ql: The patch generated 0 new + 105 unchanged - 3 fixed = 105 total (was 108)
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color}
| {color:green} service: The patch generated 0 new + 7 unchanged - 6 fixed = 7 total (was
13) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m  8s{color}
| {color:green} The patch metastore-server passed checkstyle {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch 1 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m 38s{color} | {color:red}
standalone-metastore/metastore-common generated 23 new + 5 unchanged - 4 fixed = 28 total
(was 9) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 21s{color} | {color:red}
service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 14s{color} | {color:red}
metastore-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 51s{color} | {color:red}
standalone-metastore_metastore-common generated 15 new + 4 unchanged - 0 fixed = 19 total
(was 4) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  0s{color} |
{color:green} ql in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 18s{color} |
{color:green} service in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 19s{color} |
{color:green} standalone-metastore_metastore-server generated 0 new + 49 unchanged - 13 fixed
= 49 total (was 62) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 14s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 56s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-common |
|  |  Redundant nullcheck of new_parts, which is known to be non-null in org.apache.hadoop.hive.metastore.HiveMetaStoreClient.add_partitions(List)
 Redundant null check at HiveMetaStoreClient.java:is known to be non-null in org.apache.hadoop.hive.metastore.HiveMetaStoreClient.add_partitions(List)
 Redundant null check at HiveMetaStoreClient.java:[line 749] |
|  |  Nullcheck of rsp at line 3012 of value previously dereferenced in org.apache.hadoop.hive.metastore.HiveMetaStoreClient.getNextNotification(long,
int, IMetaStoreClient$NotificationFilter)  At HiveMetaStoreClient.java:3012 of value previously
dereferenced in org.apache.hadoop.hive.metastore.HiveMetaStoreClient.getNextNotification(long,
int, IMetaStoreClient$NotificationFilter)  At HiveMetaStoreClient.java:[line 3012] |
|  |  org.apache.hadoop.hive.metastore.HiveMetaStoreClient.getTypeAll(String) makes inefficient
use of keySet iterator instead of entrySet iterator  At HiveMetaStoreClient.java:keySet iterator
instead of entrySet iterator  At HiveMetaStoreClient.java:[line 1574] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.metastore.ReplChangeManager.recycle(Path,
ReplChangeManager$RecycleType, boolean):in org.apache.hadoop.hive.metastore.ReplChangeManager.recycle(Path,
ReplChangeManager$RecycleType, boolean): String.getBytes()  At ReplChangeManager.java:[line
246] |
|  |  org.apache.hadoop.hive.metastore.Warehouse.makePartName(List, List, String) concatenates
strings using + in a loop  At Warehouse.java:using + in a loop  At Warehouse.java:[line 725]
|
|  |  Possible doublecheck on org.apache.hadoop.hive.metastore.conf.MetastoreConf.keyToVars
in org.apache.hadoop.hive.metastore.conf.MetastoreConf.get(Configuration, String)  At MetastoreConf.java:org.apache.hadoop.hive.metastore.conf.MetastoreConf.get(Configuration,
String)  At MetastoreConf.java:[lines 1594-1596] |
|  |  Boxing/unboxing to parse a primitive org.apache.hadoop.hive.metastore.conf.MetastoreConf.getLongVar(Configuration,
MetastoreConf$ConfVars)  At MetastoreConf.java:org.apache.hadoop.hive.metastore.conf.MetastoreConf.getLongVar(Configuration,
MetastoreConf$ConfVars)  At MetastoreConf.java:[line 1382] |
|  |  Incorrect lazy initialization of static field org.apache.hadoop.hive.metastore.conf.MetastoreConf.hiveSiteURL
in org.apache.hadoop.hive.metastore.conf.MetastoreConf.newMetastoreConf(Configuration)  At
MetastoreConf.java:field org.apache.hadoop.hive.metastore.conf.MetastoreConf.hiveSiteURL in
org.apache.hadoop.hive.metastore.conf.MetastoreConf.newMetastoreConf(Configuration)  At MetastoreConf.java:[lines
1184-1191] |
|  |  org.apache.hadoop.hive.metastore.conf.MetastoreConf.metaVars is a mutable array  At
MetastoreConf.java: At MetastoreConf.java:[line 143] |
|  |  Null passed for non-null parameter of new java.io.File(URI) in org.apache.hadoop.hive.metastore.conf.MetastoreConf.findConfigFile(ClassLoader,
String)  Method invoked at MetastoreConf.java:of new java.io.File(URI) in org.apache.hadoop.hive.metastore.conf.MetastoreConf.findConfigFile(ClassLoader,
String)  Method invoked at MetastoreConf.java:[line 1267] |
|  |  Null passed for non-null parameter of timeAbbreviationFor(TimeUnit) in org.apache.hadoop.hive.metastore.conf.MetastoreConf.getAsString(Configuration,
MetastoreConf$ConfVars)  Method invoked at MetastoreConf.java:of timeAbbreviationFor(TimeUnit)
in org.apache.hadoop.hive.metastore.conf.MetastoreConf.getAsString(Configuration, MetastoreConf$ConfVars)
 Method invoked at MetastoreConf.java:[line 1638] |
|  |  Rough value of 3.141592654 found:MetastoreConf.java:[line 971]  At MetastoreConf.java:[line
971] |
|  |  org.apache.hadoop.hive.metastore.partition.spec.PartitionSpecProxy$SimplePartitionWrapperIterator.next()
can't throw NoSuchElementException  At PartitionSpecProxy.java:At PartitionSpecProxy.java:[line
216] |
|  |  Possible doublecheck on org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge.self
in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge.getBridge()  At HadoopThriftAuthBridge.java:org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge.getBridge()
 At HadoopThriftAuthBridge.java:[lines 80-82] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Client$SaslClientCallbackHandler.encodeIdentifier(byte[]):in
org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Client$SaslClientCallbackHandler.encodeIdentifier(byte[]):
new String(byte[])  At HadoopThriftAuthBridge.java:[line 307] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Client$SaslClientCallbackHandler.encodePassword(byte[]):in
org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Client$SaslClientCallbackHandler.encodePassword(byte[]):
new String(byte[])  At HadoopThriftAuthBridge.java:[line 311] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Server$SaslDigestCallbackHandler.encodePassword(byte[]):in
org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Server$SaslDigestCallbackHandler.encodePassword(byte[]):
new String(byte[])  At HadoopThriftAuthBridge.java:[line 515] |
|  |  Should org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Server$TUGIAssumingProcessor
be a _static_ inner class?  At HadoopThriftAuthBridge.java:inner class?  At HadoopThriftAuthBridge.java:[lines
583-664] |
|  |  Exception is caught when Exception is not thrown in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge23.<static
initializer for HadoopThriftAuthBridge23>()  At HadoopThriftAuthBridge23.java:is not thrown
in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge23.<static initializer
for HadoopThriftAuthBridge23>()  At HadoopThriftAuthBridge23.java:[line 57] |
|  |  input must be non-null but is marked as nullable  At HdfsUtils.java:is marked as nullable
 At HdfsUtils.java:[lines 365-368] |
|  |  org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.addToClassPath(ClassLoader, String[])
creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged
block  At MetaStoreUtils.java:classloader, which should be performed within a doPrivileged
block  At MetaStoreUtils.java:[line 402] |
|  |  Public static org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.parseDbName(String,
Configuration) may expose internal representation by returning MetaStoreUtils.nullCatalogAndDatabase
 At MetaStoreUtils.java:expose internal representation by returning MetaStoreUtils.nullCatalogAndDatabase
 At MetaStoreUtils.java:[line 863] |
|  |  org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.validateName(String, Configuration)
concatenates strings using + in a loop  At MetaStoreUtils.java:+ in a loop  At MetaStoreUtils.java:[line
194] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13457/dev-support/hive-personality.sh
|
| git revision | master / b5578eb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
|
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus/patch-mvninstall-service.txt
|
| compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus/patch-compile-service.txt
|
| javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus/patch-compile-service.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus/whitespace-eol.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus/whitespace-tabs.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus/new-findbugs-standalone-metastore_metastore-common.html
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus/patch-findbugs-service.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus/diff-javadoc-javadoc-standalone-metastore_metastore-common.txt
|
| modules | C: standalone-metastore/metastore-common ql service standalone-metastore/metastore-server
U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13457/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Move common classes out of metastore-server
> -------------------------------------------
>
>                 Key: HIVE-20388
>                 URL: https://issues.apache.org/jira/browse/HIVE-20388
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>            Priority: Major
>         Attachments: HIVE-20388.01.patch, HIVE-20388.02.patch, HIVE-20388.03.patch, HIVE-20388.05.patch,
HIVE-20388.06.patch
>
>
> There are many classes in metastore-server module that should be moved to metastore-common.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message