hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20547) HS2: support Tez sessions started by someone else (part 1)
Date Fri, 14 Sep 2018 15:43:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614999#comment-16614999
] 

Hive QA commented on HIVE-20547:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 42s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 11s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 25s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 30s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 33s{color} | {color:blue}
common in master has 64 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 48s{color} | {color:blue}
itests/util in master has 52 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 59s{color} | {color:blue}
ql in master has 2311 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 39s{color} | {color:blue}
service in master has 48 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 49s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 10s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 27s{color} | {color:red}
util in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 11s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 11s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 14s{color} | {color:red}
itests/util: The patch generated 1 new + 60 unchanged - 0 fixed = 61 total (was 60) {color}
|
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 44s{color} | {color:red}
ql: The patch generated 65 new + 459 unchanged - 31 fixed = 524 total (was 490) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  2s{color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 24s{color} | {color:red}
ql generated 4 new + 2308 unchanged - 3 fixed = 2312 total (was 2311) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 48s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 58s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Result of integer multiplication cast to long in org.apache.hadoop.hive.ql.exec.tez.TezExternalSessionsRegistryClient.getSession(boolean)
 At TezExternalSessionsRegistryClient.java:to long in org.apache.hadoop.hive.ql.exec.tez.TezExternalSessionsRegistryClient.getSession(boolean)
 At TezExternalSessionsRegistryClient.java:[line 135] |
|  |  Switch statement found in org.apache.hadoop.hive.ql.exec.tez.TezSessionPoolManager.getSession(HiveConf,
boolean) where default case is missing  At TezSessionPoolManager.java:boolean) where default
case is missing  At TezSessionPoolManager.java:[lines 241-248] |
|  |  Load of known null value in org.apache.hadoop.hive.ql.exec.tez.TezSessionState.openInternal(String[],
boolean, SessionState$LogHelper, TezSession$HiveResources, boolean)  At TezSessionState.java:in
org.apache.hadoop.hive.ql.exec.tez.TezSessionState.openInternal(String[], boolean, SessionState$LogHelper,
TezSession$HiveResources, boolean)  At TezSessionState.java:[line 266] |
|  |  Dead store to sessionConf in org.apache.hadoop.hive.ql.exec.tez.WorkloadManager.reopen(TezSession)
 At WorkloadManager.java:org.apache.hadoop.hive.ql.exec.tez.WorkloadManager.reopen(TezSession)
 At WorkloadManager.java:[line 1596] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  xml  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13782/dev-support/hive-personality.sh
|
| git revision | master / 35f86c7 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13782/yetus/patch-mvninstall-itests_util.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13782/yetus/diff-checkstyle-itests_util.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13782/yetus/diff-checkstyle-ql.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13782/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13782/yetus/new-findbugs-ql.html
|
| modules | C: common itests/util ql service U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13782/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> HS2: support Tez sessions started by someone else (part 1)
> ----------------------------------------------------------
>
>                 Key: HIVE-20547
>                 URL: https://issues.apache.org/jira/browse/HIVE-20547
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Major
>         Attachments: HIVE-20547.01.patch, HIVE-20547.patch
>
>
> The registry/configs/some code is based on a private patch by [~prasanth_j].
> The patch refactors tez pool session to use composition instead of implementation inheritance
from TezSessionState, to allow for two implementations of TezSessionState.
> For now it's blocked on getClient API in Tez that will be available after 0.9.3 release;
however I commented out that path to check that refactoring passes tests.
> When 0.9.3 becomes available, we can uncomment and commit.
> In part 2, we may add some tests, and also consider other changes that are required for
external sessions (e.g. KillQuery, where we cannot assume YARN is present).
> We may also consider a WM change that allows for proportional session distribution when
the number of external sessions and the number of admin-specified sessions doesn't match,
or at least some validation to see that the external sessions are available when applying
a RP.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message