hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-19253) HMS ignores tableType property for external tables
Date Thu, 11 Oct 2018 10:35:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-19253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646255#comment-16646255
] 

Hive QA commented on HIVE-19253:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12943121/HIVE-19253.12.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 96 failed/errored test(s), 15073 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamptz_2] (batchId=85)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query10] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query11] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query12] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query13] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query15] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query16] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query17] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query18] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query19] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query1] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query20] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query21] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query22] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query23] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query24] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query25] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query26] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query27] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query29] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query2] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query30] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query31] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query32] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query33] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query34] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query35] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query36] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query37] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query38] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query39] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query3] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query40] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query42] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query43] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query44] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query45] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query46] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query47] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query48] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query49] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query4] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query50] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query51] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query52] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query53] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query54] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query55] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query56] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query57] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query58] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query59] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query5] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query60] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query61] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query63] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query64] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query65] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query66] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query67] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query68] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query69] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query6] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query70] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query71] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query72] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query73] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query74] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query75] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query76] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query77] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query78] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query79] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query7] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query80] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query81] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query82] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query83] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query84] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query85] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query86] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query87] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query88] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query89] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query8] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query90] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query91] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query92] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query93] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query94] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query95] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query96] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query97] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query98] (batchId=266)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query99] (batchId=266)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14370/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14370/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14370/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 96 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12943121 - PreCommit-HIVE-Build

> HMS ignores tableType property for external tables
> --------------------------------------------------
>
>                 Key: HIVE-19253
>                 URL: https://issues.apache.org/jira/browse/HIVE-19253
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 3.0.0, 3.1.0, 4.0.0
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>            Priority: Major
>              Labels: newbie
>         Attachments: HIVE-19253.01.patch, HIVE-19253.02.patch, HIVE-19253.03.patch, HIVE-19253.03.patch,
HIVE-19253.04.patch, HIVE-19253.05.patch, HIVE-19253.06.patch, HIVE-19253.07.patch, HIVE-19253.08.patch,
HIVE-19253.09.patch, HIVE-19253.10.patch, HIVE-19253.11.patch, HIVE-19253.12.patch
>
>
> When someone creates a table using Thrift API they may think that setting tableType to
{{EXTERNAL_TABLE}} creates an external table. And boom - their table is gone later because
HMS will silently change it to managed table.
> here is the offending code:
> {code:java}
>   private MTable convertToMTable(Table tbl) throws InvalidObjectException,
>       MetaException {
>     ...
>     // If the table has property EXTERNAL set, update table type
>     // accordingly
>     String tableType = tbl.getTableType();
>     boolean isExternal = Boolean.parseBoolean(tbl.getParameters().get("EXTERNAL"));
>     if (TableType.MANAGED_TABLE.toString().equals(tableType)) {
>       if (isExternal) {
>         tableType = TableType.EXTERNAL_TABLE.toString();
>       }
>     }
>     if (TableType.EXTERNAL_TABLE.toString().equals(tableType)) {
>       if (!isExternal) { // Here!
>         tableType = TableType.MANAGED_TABLE.toString();
>       }
>     }
> {code}
> So if the EXTERNAL parameter is not set, table type is changed to managed even if it
was external in the first place - which is wrong.
> More over, in other places code looks at the table property to decide table type and
some places look at parameter. HMS should really make its mind which one to use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message