hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20617) Fix type of constants in IN expressions to have correct type
Date Sat, 27 Oct 2018 15:50:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666139#comment-16666139
] 

Hive QA commented on HIVE-20617:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 25s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 48s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 15s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 49s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 28s{color} | {color:blue}
common in master has 65 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 40s{color} | {color:blue}
ql in master has 2317 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  4s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  9s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 35s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 12s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 12s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 36s{color} | {color:red}
ql: The patch generated 2 new + 238 unchanged - 12 fixed = 240 total (was 250) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch 1 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 51s{color} | {color:red}
ql generated 4 new + 2313 unchanged - 4 fixed = 2317 total (was 2317) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  9s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 40s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  org.apache.hadoop.hive.ql.parse.TypeCheckProcFactory$DefaultExprProcessor.interpretConstantAsPrimitive(PrimitiveTypeInfo,
Object, TypeInfo) invokes inefficient new Byte(String) constructor; use Byte.valueOf(String)
instead  At TypeCheckProcFactory.java:new Byte(String) constructor; use Byte.valueOf(String)
instead  At TypeCheckProcFactory.java:[line 1448] |
|  |  org.apache.hadoop.hive.ql.parse.TypeCheckProcFactory$DefaultExprProcessor.interpretConstantAsPrimitive(PrimitiveTypeInfo,
Object, TypeInfo) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String)
instead  At TypeCheckProcFactory.java:new Integer(String) constructor; use Integer.valueOf(String)
instead  At TypeCheckProcFactory.java:[line 1440] |
|  |  org.apache.hadoop.hive.ql.parse.TypeCheckProcFactory$DefaultExprProcessor.interpretConstantAsPrimitive(PrimitiveTypeInfo,
Object, TypeInfo) invokes inefficient new Long(String) constructor; use Long.valueOf(String)
instead  At TypeCheckProcFactory.java:new Long(String) constructor; use Long.valueOf(String)
instead  At TypeCheckProcFactory.java:[line 1442] |
|  |  org.apache.hadoop.hive.ql.parse.TypeCheckProcFactory$DefaultExprProcessor.interpretConstantAsPrimitive(PrimitiveTypeInfo,
Object, TypeInfo) invokes inefficient new Short(String) constructor; use Short.valueOf(String)
instead  At TypeCheckProcFactory.java:new Short(String) constructor; use Short.valueOf(String)
instead  At TypeCheckProcFactory.java:[line 1450] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14650/dev-support/hive-personality.sh
|
| git revision | master / 1002e89 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14650/yetus/diff-checkstyle-ql.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-14650/yetus/whitespace-eol.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-14650/yetus/whitespace-tabs.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14650/yetus/new-findbugs-ql.html
|
| modules | C: common ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14650/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Fix type of constants in IN expressions to have correct type
> ------------------------------------------------------------
>
>                 Key: HIVE-20617
>                 URL: https://issues.apache.org/jira/browse/HIVE-20617
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>         Attachments: HIVE-20617.01.patch, HIVE-20617.02.patch, HIVE-20617.03.patch, HIVE-20617.05.patch,
HIVE-20617.06.patch, HIVE-20617.07.patch, HIVE-20617.08.patch, HIVE-20617.08.patch, HIVE-20617.08.patch,
HIVE-20617.08.patch, HIVE-20617.08.patch, HIVE-20617.08.patch, HIVE-20617.08.patch, HIVE-20617.08.patch,
HIVE-20617.09.patch, HIVE-20617.10.patch, HIVE-20617.10.patch, HIVE-20617.11.patch, HIVE-20617.11.patch,
HIVE-20617.12.patch
>
>
> In statements like {{struct(a,b) IN (const struct('x','y'), ... )}} the comparision in
UDFIn may fail because if a or b is of char/varchar type the constants will retain string
type - especially after PointlookupOptimizer compaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message