hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20720) Add partition column option to JDBC handler
Date Thu, 18 Oct 2018 22:34:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655988#comment-16655988
] 

Hive QA commented on HIVE-20720:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 30s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 42s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 36s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m  2s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 31s{color} | {color:blue}
common in master has 65 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 23s{color} | {color:blue}
jdbc-handler in master has 10 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 57s{color} | {color:blue}
ql in master has 2318 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 24s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 10s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 59s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 37s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 37s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 11s{color} | {color:red}
jdbc-handler: The patch generated 111 new + 64 unchanged - 5 fixed = 175 total (was 69) {color}
|
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 30s{color} | {color:red}
jdbc-handler generated 5 new + 7 unchanged - 3 fixed = 12 total (was 10) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 18s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 40s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:jdbc-handler |
|  |  Dead store to dbAccessor in org.apache.hive.storage.jdbc.JdbcSerDe.initialize(Configuration,
Properties)  At JdbcSerDe.java:org.apache.hive.storage.jdbc.JdbcSerDe.initialize(Configuration,
Properties)  At JdbcSerDe.java:[line 77] |
|  |  org.apache.hive.storage.jdbc.dao.GenericJdbcDatabaseAccessor.getBounds(Configuration,
String, boolean, boolean) may fail to clean up java.sql.ResultSet  Obligation to clean up
resource created at GenericJdbcDatabaseAccessor.java:fail to clean up java.sql.ResultSet 
Obligation to clean up resource created at GenericJdbcDatabaseAccessor.java:[line 376] is
not discharged |
|  |  org.apache.hive.storage.jdbc.dao.GenericJdbcDatabaseAccessor.getBounds(Configuration,
String, boolean, boolean) may fail to clean up java.sql.Statement  Obligation to clean up
resource created at GenericJdbcDatabaseAccessor.java:fail to clean up java.sql.Statement 
Obligation to clean up resource created at GenericJdbcDatabaseAccessor.java:[line 375] is
not discharged |
|  |  org.apache.hive.storage.jdbc.dao.GenericJdbcDatabaseAccessor.getRecordIterator(Configuration,
String, String, String, int, int) may fail to clean up java.sql.Statement on checked exception
 Obligation to clean up resource created at GenericJdbcDatabaseAccessor.java:int) may fail
to clean up java.sql.Statement on checked exception  Obligation to clean up resource created
at GenericJdbcDatabaseAccessor.java:[line 168] is not discharged |
|  |  A prepared statement is generated from a nonconstant String in org.apache.hive.storage.jdbc.dao.GenericJdbcDatabaseAccessor.getBounds(Configuration,
String, boolean, boolean)   At GenericJdbcDatabaseAccessor.java:from a nonconstant String
in org.apache.hive.storage.jdbc.dao.GenericJdbcDatabaseAccessor.getBounds(Configuration, String,
boolean, boolean)   At GenericJdbcDatabaseAccessor.java:[line 375] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14553/dev-support/hive-personality.sh
|
| git revision | master / a2bbf79 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14553/yetus/diff-checkstyle-jdbc-handler.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-14553/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14553/yetus/new-findbugs-jdbc-handler.html
|
| modules | C: common itests jdbc-handler ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14553/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Add partition column option to JDBC handler
> -------------------------------------------
>
>                 Key: HIVE-20720
>                 URL: https://issues.apache.org/jira/browse/HIVE-20720
>             Project: Hive
>          Issue Type: New Feature
>          Components: StorageHandler
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>            Priority: Major
>         Attachments: HIVE-20720.1.patch, HIVE-20720.10.patch, HIVE-20720.2.patch, HIVE-20720.3.patch,
HIVE-20720.4.patch, HIVE-20720.5.patch, HIVE-20720.6.patch, HIVE-20720.7.patch, HIVE-20720.8.patch,
HIVE-20720.9.patch
>
>
> Currently JdbcStorageHandler does not split input in Tez. The reason is numSplit of JdbcInputFormat.getSplits
can only pass via "mapreduce.job.maps" in Tez. And "mapreduce.job.maps" is not a valid param
if authorizer(eg. SQLStdAuth) is in use. User ends up always use 1 split.
> We need to rely on this new feature if we want to support multi-splits. Here is my proposal:
> 1. Specify partitionColumn/numPartitions, and optional lowerBound/upperBound in tblproperties
if user want to split jdbc data source. In case lowerBound/upperBound is not specified, JdbcStorageHandler
will run max/min query to get this in planner. We can currently limit partitionColumn to only
numeric/date/timestamp column for simplicity
> 2. If partitionColumn/numPartitions are not specified, don't split input
> 3. Splits are equal intervals without respect to data distribution
> 4. There is also a "hive.sql.query.split" flag vetos the split (can be set manually or
automatically by calcite)
> 5. If partitionColumn is not defined, but numPartitions is defined, use original limit/offset
logic (however, don't rely on numSplit).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message